From: Johan Hedberg <johan.hedberg@gmail.com>
To: Claudio Takahasi <claudio.takahasi@openbossa.org>
Cc: BlueZ development <linux-bluetooth@vger.kernel.org>
Subject: Re: Pull request: git://git.infradead.org/users/cktakahasi/bluez.git for-upstream
Date: Thu, 30 Sep 2010 10:39:38 +0300 [thread overview]
Message-ID: <20100930073938.GA6964@jh-x301> (raw)
In-Reply-To: <AANLkTimvvp=D+X+TcP3Ji7WuGaMZF7+LA+8BWZiQCStr@mail.gmail.com>
Hi Claudio,
On Wed, Sep 29, 2010, Claudio Takahasi wrote:
> StartDiscovery() triggers all the process. The adapter type: BR/EDR
> only/LE only or dual mode is hidden from the higher layers.
> So, your suggestion it try to hide all discovery details inside the
> hciops as much as possible?
That was the idea yes, but I'm not 100% sure that it's the best
approach. Another question is also how do we want to represent this with
the new management interface. Should the kernel do it "all" through a
single request from userspace or should userspace control the separate
BR/EDR and LE discoveries. If it's the former, then having a single
adapter_ops callback makes sense. If it's the later then we should
probably have two separate ones. Either way I now realize that to
implement this with a single callback we'd need to have the HCI event
processing moved over to hciops and that's not something that will
happen very quickly. So maybe it's better to have these as two separate
adapter_ops callbacks for now.
Johan
next prev parent reply other threads:[~2010-09-30 7:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-23 16:19 Pull request: git://git.infradead.org/users/cktakahasi/bluez.git for-upstream Claudio Takahasi
2010-09-23 17:55 ` Luiz Augusto von Dentz
2010-09-23 18:07 ` Claudio Takahasi
2010-09-29 13:45 ` Johan Hedberg
2010-09-29 14:05 ` Claudio Takahasi
2010-09-30 7:39 ` Johan Hedberg [this message]
2010-09-30 14:28 ` Claudio Takahasi
2010-09-30 21:51 ` Claudio Takahasi
2010-10-04 17:27 ` Claudio Takahasi
2010-10-04 20:43 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100930073938.GA6964@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=claudio.takahasi@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox