From: "Gustavo F. Padovan" <padovan@profusion.mobi>
To: "Haijun.Liu" <haijun.liu@atheros.com>
Cc: linux-bluetooth@vger.kernel.org, ville.tervo@nokia.com,
dan.tian@atheros.com, suraj@atheros.com
Subject: Re: [PATCH 1/2] Bluetooth: Replace hard code of configuration flag with self-comment macro.
Date: Thu, 30 Sep 2010 10:56:18 -0300 [thread overview]
Message-ID: <20100930135618.GA4615@vigoh> (raw)
In-Reply-To: <1285836760-3234-1-git-send-email-haijun.liu@atheros.com>
Hi Haijun,
* Haijun.Liu <haijun.liu@atheros.com> [2010-09-30 16:52:39 +0800]:
>
> Signed-off-by: Haijun.Liu <haijun.liu@atheros.com>
> ---
> net/bluetooth/l2cap_core.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
Your patch doesn't build:
net/bluetooth/l2cap_core.c: In function 'l2cap_config_req':
net/bluetooth/l2cap_core.c:2988: error: 'L2CAP_CONF_FLAG_CONT'
undeclared (first use in this function)
net/bluetooth/l2cap_core.c:2988: error: (Each undeclared identifier is
reported only once
net/bluetooth/l2cap_core.c:2988: error: for each function it appears
in.)
net/bluetooth/l2cap_core.c: In function 'l2cap_config_rsp':
net/bluetooth/l2cap_core.c:3096: error: 'L2CAP_CONF_FLAG_CONT'
undeclared (first use in this function)
You also have to fix your commit subject, it would be good if you can do
it with 50 characters, but never overstep the 72 characters. If need to
add more info the commit message is there for you ;)
--
Gustavo F. Padovan
ProFUSION embedded systems - http://profusion.mobi
next parent reply other threads:[~2010-09-30 13:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1285836760-3234-1-git-send-email-haijun.liu@atheros.com>
2010-09-30 13:56 ` Gustavo F. Padovan [this message]
2010-10-01 14:40 ` [PATCH 1/2] Bluetooth: Replace hard code of configuration flag with self-comment macro haijun liu
[not found] ` <1285836760-3234-2-git-send-email-haijun.liu@atheros.com>
2010-09-30 14:00 ` [PATCH 2/2] Bluetooth: Update conf_state with L2CAP_CONF_REQ_SENT before send config_req out in l2cap_config_req() Gustavo F. Padovan
2010-10-01 14:31 ` haijun liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100930135618.GA4615@vigoh \
--to=padovan@profusion.mobi \
--cc=dan.tian@atheros.com \
--cc=haijun.liu@atheros.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=suraj@atheros.com \
--cc=ville.tervo@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).