* Re: [PATCH 1/2] Bluetooth: Replace hard code of configuration flag with self-comment macro. [not found] <1285836760-3234-1-git-send-email-haijun.liu@atheros.com> @ 2010-09-30 13:56 ` Gustavo F. Padovan 2010-10-01 14:40 ` haijun liu [not found] ` <1285836760-3234-2-git-send-email-haijun.liu@atheros.com> 1 sibling, 1 reply; 4+ messages in thread From: Gustavo F. Padovan @ 2010-09-30 13:56 UTC (permalink / raw) To: Haijun.Liu; +Cc: linux-bluetooth, ville.tervo, dan.tian, suraj Hi Haijun, * Haijun.Liu <haijun.liu@atheros.com> [2010-09-30 16:52:39 +0800]: > > Signed-off-by: Haijun.Liu <haijun.liu@atheros.com> > --- > net/bluetooth/l2cap_core.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) Your patch doesn't build: net/bluetooth/l2cap_core.c: In function 'l2cap_config_req': net/bluetooth/l2cap_core.c:2988: error: 'L2CAP_CONF_FLAG_CONT' undeclared (first use in this function) net/bluetooth/l2cap_core.c:2988: error: (Each undeclared identifier is reported only once net/bluetooth/l2cap_core.c:2988: error: for each function it appears in.) net/bluetooth/l2cap_core.c: In function 'l2cap_config_rsp': net/bluetooth/l2cap_core.c:3096: error: 'L2CAP_CONF_FLAG_CONT' undeclared (first use in this function) You also have to fix your commit subject, it would be good if you can do it with 50 characters, but never overstep the 72 characters. If need to add more info the commit message is there for you ;) -- Gustavo F. Padovan ProFUSION embedded systems - http://profusion.mobi ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] Bluetooth: Replace hard code of configuration flag with self-comment macro. 2010-09-30 13:56 ` [PATCH 1/2] Bluetooth: Replace hard code of configuration flag with self-comment macro Gustavo F. Padovan @ 2010-10-01 14:40 ` haijun liu 0 siblings, 0 replies; 4+ messages in thread From: haijun liu @ 2010-10-01 14:40 UTC (permalink / raw) To: Gustavo F. Padovan Cc: Haijun.Liu, linux-bluetooth, ville.tervo, dan.tian, suraj Hi Gustavo, On Thu, Sep 30, 2010 at 9:56 PM, Gustavo F. Padovan <padovan@profusion.mobi> wrote: > Hi Haijun, > > * Haijun.Liu <haijun.liu@atheros.com> [2010-09-30 16:52:39 +0800]: > >> >> Signed-off-by: Haijun.Liu <haijun.liu@atheros.com> >> --- >> net/bluetooth/l2cap_core.c | 6 +++--- >> 1 files changed, 3 insertions(+), 3 deletions(-) > > Your patch doesn't build: > > net/bluetooth/l2cap_core.c: In function 'l2cap_config_req': > net/bluetooth/l2cap_core.c:2988: error: 'L2CAP_CONF_FLAG_CONT' > undeclared (first use in this function) > net/bluetooth/l2cap_core.c:2988: error: (Each undeclared identifier is > reported only once > net/bluetooth/l2cap_core.c:2988: error: for each function it appears > in.) > net/bluetooth/l2cap_core.c: In function 'l2cap_config_rsp': > net/bluetooth/l2cap_core.c:3096: error: 'L2CAP_CONF_FLAG_CONT' > undeclared (first use in this function) > > > You also have to fix your commit subject, it would be good if you can do > it with 50 characters, but never overstep the 72 characters. If need to > add more info the commit message is there for you ;) > > -- > Gustavo F. Padovan > ProFUSION embedded systems - http://profusion.mobi > -- > To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Sorry for this mistake, I'll mail out right one soon. -- Haijun Liu ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <1285836760-3234-2-git-send-email-haijun.liu@atheros.com>]
* Re: [PATCH 2/2] Bluetooth: Update conf_state with L2CAP_CONF_REQ_SENT before send config_req out in l2cap_config_req(). [not found] ` <1285836760-3234-2-git-send-email-haijun.liu@atheros.com> @ 2010-09-30 14:00 ` Gustavo F. Padovan 2010-10-01 14:31 ` haijun liu 0 siblings, 1 reply; 4+ messages in thread From: Gustavo F. Padovan @ 2010-09-30 14:00 UTC (permalink / raw) To: Haijun.Liu; +Cc: linux-bluetooth, ville.tervo, dan.tian, suraj Hi Haijun, * Haijun.Liu <haijun.liu@atheros.com> [2010-09-30 16:52:40 +0800]: > > Signed-off-by: Haijun.Liu <haijun.liu@atheros.com> > --- > net/bluetooth/l2cap_core.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c > index 279f98a..9e788c2 100644 > --- a/net/bluetooth/l2cap_core.c > +++ b/net/bluetooth/l2cap_core.c Patch has been applied to my bluetooth-next-2.6 tree with modifications to the commit message and subject. Next time pay attention to not overstep the 72 characters in the commit subject and do not add a "." in the end of your subject. Thanks. -- Gustavo F. Padovan ProFUSION embedded systems - http://profusion.mobi ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] Bluetooth: Update conf_state with L2CAP_CONF_REQ_SENT before send config_req out in l2cap_config_req(). 2010-09-30 14:00 ` [PATCH 2/2] Bluetooth: Update conf_state with L2CAP_CONF_REQ_SENT before send config_req out in l2cap_config_req() Gustavo F. Padovan @ 2010-10-01 14:31 ` haijun liu 0 siblings, 0 replies; 4+ messages in thread From: haijun liu @ 2010-10-01 14:31 UTC (permalink / raw) To: Gustavo F. Padovan Cc: Haijun.Liu, linux-bluetooth, ville.tervo, dan.tian, suraj Hi Gustavo, On Thu, Sep 30, 2010 at 10:00 PM, Gustavo F. Padovan <padovan@profusion.mobi> wrote: > Hi Haijun, > > * Haijun.Liu <haijun.liu@atheros.com> [2010-09-30 16:52:40 +0800]: > >> >> Signed-off-by: Haijun.Liu <haijun.liu@atheros.com> >> --- >> net/bluetooth/l2cap_core.c | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c >> index 279f98a..9e788c2 100644 >> --- a/net/bluetooth/l2cap_core.c >> +++ b/net/bluetooth/l2cap_core.c > > Patch has been applied to my bluetooth-next-2.6 tree with modifications > to the commit message and subject. Next time pay attention to not > overstep the 72 characters in the commit subject and do not add a "." in > the end of your subject. Thanks. > > -- > Gustavo F. Padovan > ProFUSION embedded systems - http://profusion.mobi > -- > To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Thank you. -- Haijun Liu ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-10-01 14:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1285836760-3234-1-git-send-email-haijun.liu@atheros.com>
2010-09-30 13:56 ` [PATCH 1/2] Bluetooth: Replace hard code of configuration flag with self-comment macro Gustavo F. Padovan
2010-10-01 14:40 ` haijun liu
[not found] ` <1285836760-3234-2-git-send-email-haijun.liu@atheros.com>
2010-09-30 14:00 ` [PATCH 2/2] Bluetooth: Update conf_state with L2CAP_CONF_REQ_SENT before send config_req out in l2cap_config_req() Gustavo F. Padovan
2010-10-01 14:31 ` haijun liu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).