From: Johan Hedberg <johan.hedberg@gmail.com>
To: Claudio Takahasi <claudio.takahasi@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 2/2] Client Characteristic Configuration on attribute server
Date: Wed, 6 Oct 2010 23:43:03 +0200 [thread overview]
Message-ID: <20101006214303.GB21610@jh-x301> (raw)
In-Reply-To: <1286397594-12366-2-git-send-email-claudio.takahasi@openbossa.org>
Hi Claudio,
On Wed, Oct 06, 2010, Claudio Takahasi wrote:
> Initial implementation of per client attribute configuration for the
> attribute server. Notification and indication shall be sent to the peer
> only if Client Characteristic Configuration bit field is set.
> ---
> TODO | 7 --
> src/attrib-server.c | 194 +++++++++++++++++++++++++++++++++++---------------
> src/storage.c | 44 ++++++++++++
> src/storage.h | 4 +
> 4 files changed, 184 insertions(+), 65 deletions(-)
I feel a bit conflicted about this one. Do we really want to have a
generic storage for all characteristics? I'd think that it'd make sense
to let each service implementation take care of how to store their state
persistently (if it needs to be done at all).
Would it be possible for you to create a patch that fixes the
notification sending to clients that haven't subscribed for them but
leaves out the storage stuff?
Johan
next prev parent reply other threads:[~2010-10-06 21:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-06 20:39 [PATCH 1/2] Change Battery Service on attribute sample server Claudio Takahasi
2010-10-06 20:39 ` [PATCH 2/2] Client Characteristic Configuration on attribute server Claudio Takahasi
2010-10-06 21:43 ` Johan Hedberg [this message]
2010-10-07 13:50 ` Claudio Takahasi
2010-10-06 21:40 ` [PATCH 1/2] Change Battery Service on attribute sample server Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101006214303.GB21610@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=claudio.takahasi@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox