Re: Pull request git://gitorious.org/bluez-mcap-hdp/mcap-hdp.git for_upstream

[Johan Hedberg <johan.hedberg@gmail.com>]

Hi Jose,

On Tue, Oct 12, 2010, Jose Antonio Santos Cadenas wrote:
> >> On Tue, Oct 12, 2010, Jose Antonio Santos Cadenas wrote:
> >>> I'm sorry but I can't connect to the IRC rigth now. Nevertheless, I
> >>> think that I've found the issues:
> >>>
> >>> - The iochannel should be unrefereed when the watcher is explicitly removed
> >>
> >> Yes, though do you need to have a reference at all? As long as you have
> >> the GLib watch callback GLib itself holds a reference, so if you don't
> >> need one just remove chan->echo_chan and do an unref after calling
> >> add_watch.
> >
> > Sorry I've forgot this one. Gonna solve it.
> 
> Solved, I've removed the chan->echo_chan attribute and directly unref
> the io_channel once the watcher is set.

Thanks. The patches have now been pushed upstream.

Johan