Linux bluetooth development
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@nokia.com>
To: Dmitriy Paliy <dmitriy.paliy@nokia.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Fix suspend stream on opening if no data
Date: Wed, 13 Oct 2010 15:30:44 +0300	[thread overview]
Message-ID: <20101013123044.GA2821@jh-x301> (raw)
In-Reply-To: <1286972456-6168-2-git-send-email-dmitriy.paliy@nokia.com>

Hi Dmitriy,

On Wed, Oct 13, 2010, Dmitriy Paliy wrote:
> Fix write to stream and suspend it immidiately if there is no data
> available.
> ---
>  src/obex.c |   14 +++++++++++++-
>  1 files changed, 13 insertions(+), 1 deletions(-)

Looks good. The patch has been pushed upstream. Do pay attention to
whitespace issues in the future though. I got this when applying it:

Applying: Fix suspend stream on opening if no data
/home/jh/src/obexd/.git/rebase-apply/patch:18: trailing whitespace.
warning: 1 line applied after fixing whitespace errors.

This came from the empty line with two tabs after the AddHeader call:

>  		OBEX_ObjectAddHeader (obex, obj, OBEX_HDR_BODY,
>  				hd, 0, OBEX_FL_STREAM_START);
> +		

Johan

      parent reply	other threads:[~2010-10-13 12:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-13 12:20 [PATCH 0/1] Fix suspend stream on opening if no data Dmitriy Paliy
2010-10-13 12:20 ` [PATCH] " Dmitriy Paliy
2010-10-13 12:24   ` Bastien Nocera
2010-10-13 12:30   ` Johan Hedberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101013123044.GA2821@jh-x301 \
    --to=johan.hedberg@nokia.com \
    --cc=dmitriy.paliy@nokia.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox