From: Johan Hedberg <johan.hedberg@gmail.com>
To: Rafal Michalski <michalski.raf@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Adjust mce_bt_set flag to gboolean type values
Date: Wed, 13 Oct 2010 17:24:04 +0300 [thread overview]
Message-ID: <20101013142403.GC4828@jh-x301> (raw)
In-Reply-To: <1286975300-2832-1-git-send-email-michalski.raf@gmail.com>
Hi Rafal,
On Wed, Oct 13, 2010, Rafal Michalski wrote:
> - mce_bt_set = !!(sigvalue & MCE_RADIO_STATE_BLUETOOTH);
> + mce_bt_set = sigvalue & MCE_RADIO_STATE_BLUETOOTH ?
> + TRUE : FALSE;
Ok, that's basically a coding style fix.
> - mce_bt_set = radio_states & MCE_RADIO_STATE_BLUETOOTH;
> + mce_bt_set = radio_states & MCE_RADIO_STATE_BLUETOOTH ? TRUE : FALSE;
And that's a clear bug fix (since there's no guarantee that the binary
and results in the value 1 or TRUE).
In principle I'd prefer having coding style patches separate from real
bug fixes (even for trivial changes), but since these are related I've
let it go for now and pushed the patch upstream.
Johan
prev parent reply other threads:[~2010-10-13 14:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-13 13:08 [PATCH] Adjust mce_bt_set flag to gboolean type values Rafal Michalski
2010-10-13 14:24 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101013142403.GC4828@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=michalski.raf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox