From: Johan Hedberg <johan.hedberg@nokia.com>
To: Dmitriy Paliy <dmitriy.paliy@nokia.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 0/2] Fix regression on suspend on opening
Date: Fri, 15 Oct 2010 10:21:53 +0300 [thread overview]
Message-ID: <20101015072153.GA3409@jh-x301> (raw)
In-Reply-To: <1287125828-5479-1-git-send-email-dmitriy.paliy@nokia.com>
Hi Dmitriy,
On Fri, Oct 15, 2010, Dmitriy Paliy wrote:
> This fixes regression when doing suspend on opening obex stream. If
> obex_write_stream returns length of buffer, it is treated as an error
> response later on, which is not correct.
>
> Negative values returned by obex_write_stream are error codes, while
> positive ones mean length of buffer. Positive values are never used
> afterwards in the code. Therefore, due to this reason, and for being
> compliant with obex_read_stream, which also returns 0 only, it was
> decided to remove return of positive value representing length at all.
>
> Result of such is also some code cleanup that removes unnecessary return
> len when it is zero.
>
> A typo is fixed in comments as well.
Both patches have been pushed upstream. Thanks. Btw, don't be afraid to
put this kind of explanations in the commit messages themselves since
that info is easier to find in a couple of years time than this cover
letter email.
Johan
next prev parent reply other threads:[~2010-10-15 7:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 6:57 [PATCH 0/2] Fix regression on suspend on opening Dmitriy Paliy
2010-10-15 6:57 ` [PATCH 1/2] " Dmitriy Paliy
2010-10-15 6:57 ` [PATCH 2/2] Code cleanup: unnecessary operation and typo removed Dmitriy Paliy
2010-10-15 7:21 ` Johan Hedberg [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-10-14 12:35 [PATCH 0/2] Fix regression on suspend on opening Dmitriy Paliy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101015072153.GA3409@jh-x301 \
--to=johan.hedberg@nokia.com \
--cc=dmitriy.paliy@nokia.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox