From: "Gustavo F. Padovan" <padovan@profusion.mobi>
To: Mike Frysinger <vapier@gentoo.org>
Cc: Harvey Harrison <harvey.harrison@gmail.com>,
linux-bluetooth@vger.kernel.org,
Marcel Holtmann <marcel@holtmann.org>,
uclinux-dist-devel@blackfin.uclinux.org,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
steven miao <realmz6@gmail.com>
Subject: Re: [PATCH] bluetooth: fix unaligned access to l2cap conf data
Date: Mon, 18 Oct 2010 17:12:10 -0200 [thread overview]
Message-ID: <20101018191209.GE2468@vigoh> (raw)
In-Reply-To: <AANLkTin3Tx8jyR47G3SNbP_zFJ+tGdR6FtraHmM2T79j@mail.gmail.com>
* Mike Frysinger <vapier@gentoo.org> [2010-10-18 15:10:36 -0400]:
> On Mon, Oct 18, 2010 at 12:32, Gustavo F. Padovan wrote:
> > * Harvey Harrison <harvey.harrison@gmail.com> [2010-10-18 11:17:28 -070=
0]:
> >> On Sat, Oct 16, 2010 at 3:29 PM, Mike Frysinger <vapier@gentoo.org> wr=
ote:
> >> > From: steven miao <realmz6@gmail.com>
> >> >
> >> > =A0 =A0 =A0 =A0case 2:
> >> > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 *((__le16 *) opt->val) =3D cpu_to_le16=
(val);
> >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 put_unaligned_le16(cpu_to_le16(val), o=
pt->val);
> >> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0break;
> >>
> >> I think you wanted:
> >> put_unaligned_le16(val, opt->val);
> >
> > I fixed that in the tree. Thanks for the report.
>=20
> i guess you fixed the 32bit one too ?
> put_unaligned_le32(cpu_to_le32(val), opt->val);
Yes, I did.
--=20
Gustavo F. Padovan
ProFUSION embedded systems - http://profusion.mobi
next prev parent reply other threads:[~2010-10-18 19:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-16 22:29 [PATCH] bluetooth: fix unaligned access to l2cap conf data Mike Frysinger
2010-10-18 11:51 ` Marcel Holtmann
2010-10-18 15:59 ` Gustavo F. Padovan
2010-10-18 18:17 ` Harvey Harrison
2010-10-18 16:32 ` Gustavo F. Padovan
2010-10-18 19:10 ` Mike Frysinger
2010-10-18 19:12 ` Gustavo F. Padovan [this message]
2010-10-18 19:39 ` Mike Frysinger
[not found] <1283149112-22164-1-git-send-email-realmz6@gmail.com>
2010-09-17 3:13 ` [PATCH] Bluetooth: Fix " real mz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101018191209.GE2468@vigoh \
--to=padovan@profusion.mobi \
--cc=akpm@linux-foundation.org \
--cc=harvey.harrison@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=realmz6@gmail.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).