From: Johan Hedberg <johan.hedberg@gmail.com>
To: Balamurugan Mahalingam <mbalamurugan@atheros.com>
Cc: marcel@holtmann.org, linux-bluetooth@vger.kernel.org,
charubala@charubala.com
Subject: Re: [PATCH] hidd shows different names for same device when connected from GUI and CLI.
Date: Tue, 19 Oct 2010 17:09:16 +0300 [thread overview]
Message-ID: <20101019140916.GA14730@jh-x301> (raw)
In-Reply-To: <1287496282-16170-1-git-send-email-mbalamurugan@atheros.com>
Hi,
On Tue, Oct 19, 2010, Balamurugan Mahalingam wrote:
> Blueman and other GUIs use the string from ServiceName attribute as
> device name in the SDP response, but hidd tool uses strings from
> Service Description and Provider Name atrribute.
>
> SDP response from Microsoft Bluetooth device has extended ASCII
> character 174(registered symbol) in its ServiceDescription attribute.
> Android platform expects the device name to have only printable
> characters and therefore GUI Crashes while connecting Microsoft
> Bluetooth Mouse using hidd
>
> Using the ServiceName attribute from the SDP response
> instead of ProviderName+ServiceDescription for device name in the
> hidd tool solves both the issues.
> ---
> compat/sdp.c | 33 +++++++++++++++++----------------
> 1 files changed, 17 insertions(+), 16 deletions(-)
Same issues as with the previous commit message. Lines should be max 74
characters long and please redo the summary line to be of the format
"Fix ..." and shorter than it is now.
Btw, why are you using hidd and not the bluetoothd input plugin? hidd is
legacy stuff which will disappear from BlueZ in the future.
Johan
next prev parent reply other threads:[~2010-10-19 14:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 13:51 [PATCH] hidd shows different names for same device when connected from GUI and CLI Balamurugan Mahalingam
2010-10-19 14:09 ` Johan Hedberg [this message]
2010-10-20 9:12 ` Balamurugan Mahalingam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101019140916.GA14730@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=charubala@charubala.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mbalamurugan@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).