From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 2/3] bluetooth: Remove some unnecessary error messages
Date: Tue, 19 Oct 2010 17:01:18 +0100 [thread overview]
Message-ID: <20101019160118.GA25861@srcf.ucam.org> (raw)
In-Reply-To: <1287402917.3316.128.camel@aeonflux>
On Mon, Oct 18, 2010 at 01:55:17PM +0200, Marcel Holtmann wrote:
> Hi Matthew,
>
> > The main reason for these urbs to error out on submission is that runtime
> > pm has kicked in, which is unnecessary noise. Let's just drop them.
>
> do we wanna remove them or just turn into BT_DBG which is under dynamic
> debug control. Or do we have a set of error results that we do wanna
> print and others that we wanna ignore?
BT_DBG doesn't seem like an obvious problem. Are there any cases where
this will actually trigger in a problematic way?
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2010-10-19 16:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-16 17:58 [PATCH 1/3] bluetooth: Take a runtime pm reference on hid connections Matthew Garrett
2010-09-16 17:58 ` [PATCH 2/3] bluetooth: Remove some unnecessary error messages Matthew Garrett
2010-09-17 8:33 ` Andrei Emeltchenko
2010-09-17 8:59 ` Oliver Neukum
2010-10-18 11:55 ` Marcel Holtmann
2010-10-19 16:01 ` Matthew Garrett [this message]
2010-09-16 17:58 ` [PATCH 3/3] bluetooth: Enable USB autosuspend by default on btusb Matthew Garrett
2010-10-13 10:00 ` Marcel Holtmann
2010-10-18 6:06 ` Gustavo F. Padovan
2010-09-17 8:39 ` [PATCH 1/3] bluetooth: Take a runtime pm reference on hid connections Oliver Neukum
2010-09-17 12:24 ` Matthew Garrett
2010-10-13 9:32 ` Marcel Holtmann
2010-10-19 16:03 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101019160118.GA25861@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).