From: "Gustavo F. Padovan" <padovan@profusion.mobi>
To: Haijun Liu <haijun.liu@atheros.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/2 v2] Bluetooth: Fix system crash caused by del_timer()
Date: Fri, 22 Oct 2010 15:18:25 -0200 [thread overview]
Message-ID: <20101022171825.GA980@vigoh> (raw)
In-Reply-To: <1287714419-13545-1-git-send-email-haijun.liu@atheros.com>
* Haijun Liu <haijun.liu@atheros.com> [2010-10-22 10:26:58 +0800]:
> During test session with another vendor's bt stack, found that in
> l2cap_chan_del() using del_timer() caused l2cap_monitor_timeout()
> be called after the sock was freed, so it raised a system crash.
> So I just replaced del_timer() with del_timer_sync() to solve it.
NAK on this. If you read the del_timer_sync() documentation you can
see that you can't call del_timer_sync() on interrupt context. The
possible solution here is to check in the beginning of
l2cap_monitor_timeout() if your sock is still valid.
--
Gustavo F. Padovan
ProFUSION embedded systems - http://profusion.mobi
next prev parent reply other threads:[~2010-10-22 17:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 2:26 [PATCH 1/2 v2] Bluetooth: Fix system crash caused by del_timer() Haijun Liu
2010-10-22 2:26 ` [PATCH 2/2 v2] Bluetooth: Fix system crash bug of no send queue protect Haijun Liu
2010-10-22 17:34 ` Gustavo F. Padovan
2010-10-25 2:15 ` haijun liu
2010-10-25 11:09 ` Gustavo F. Padovan
2010-10-26 11:50 ` haijun liu
2010-10-22 17:18 ` Gustavo F. Padovan [this message]
2010-10-25 1:35 ` [PATCH 1/2 v2] Bluetooth: Fix system crash caused by del_timer() haijun liu
2010-10-25 2:21 ` haijun liu
2010-10-25 11:01 ` Gustavo F. Padovan
2010-10-26 1:32 ` haijun liu
[not found] ` <AANLkTin+dNkjySQBvCSLK9f5aRF9445UqjhXaNvKWSz_@mail.gmail.com>
2010-10-26 7:35 ` haijun liu
2010-10-28 8:49 ` Gustavo F. Padovan
2010-11-01 1:22 ` haijun liu
2010-11-03 17:56 ` Gustavo F. Padovan
2010-11-03 21:12 ` Mat Martineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101022171825.GA980@vigoh \
--to=padovan@profusion.mobi \
--cc=haijun.liu@atheros.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).