Re: [PATCH] Provide extra query for vCard single call

[Johan Hedberg <johan.hedberg@gmail.com>]

Hi Rafal,

On Mon, Oct 25, 2010, Rafal Michalski wrote:
> This patch makes that additional circumstance is recognized - after
> making a call with number that is out of phonebook it can be downloaded
> as a single vCard containing number with OTHER type.
> ---
>  plugins/phonebook-tracker.c |   20 ++++++++++++++++++--
>  1 files changed, 18 insertions(+), 2 deletions(-)

Pushed upstream, but I had to fix your coding style first:

> -	query = g_strdup_printf(CONTACTS_QUERY_FROM_URI, id, id, id, id, id,
> -						id, id, id, id, id, id, id,
> +	if (strncmp(id, CONTACT_ID_PREFIX, strlen(CONTACT_ID_PREFIX)) == 0) {
> +		query = g_strdup_printf(CONTACTS_QUERY_FROM_URI, id, id, id, id,
> +						id, id, id, id, id, id, id, id,
>  						id, id, id, id, id);
> +	} else {
> +		query = g_strdup_printf(CONTACTS_OTHER_QUERY_FROM_URI,
> +								id, id, id);
> +	}
>  
>  	ret = query_tracker(query, PULL_QUERY_COL_AMOUNT, pull_contacts, data);

Single line branches shouldn't use curly braces.

Johan