From: Arnd Bergmann <arnd@arndb.de>
To: "Par-Gunnar Hjalmdahl" <pghatwork@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
linus.walleij@stericsson.com, linux-bluetooth@vger.kernel.org,
linux-kernel@vger.kernel.org, Lukasz.Rymanowski@tieto.com
Subject: Re: [PATCH 5/9] mfd: Add UART support for the ST-Ericsson CG2900.
Date: Thu, 28 Oct 2010 14:22:46 +0200 [thread overview]
Message-ID: <201010281422.46687.arnd@arndb.de> (raw)
In-Reply-To: <AANLkTik-S50ZX6mFG+vWhBv0x_WmipP=t+4VqmAgssRC@mail.gmail.com>
On Friday 22 October 2010, Par-Gunnar Hjalmdahl wrote:
> >
> > So - NAK this for the moment, it needs to be split cleanly into ldisc
> > (thing which speaks the protocol and eg sees "speed change required" and
> > acts on it) and device (thing which knows about the hardware).
>
> OK. We will try to figure out a new design.
> I'm not too happy about putting the ldisc part in Bluetooth though
> since it is only partly Bluetooth, it is also GPS and FM. Better could
> maybe be under char/?
After getting a better idea of what the base mfd driver does, my impression
is now that you should not register a second N_HCI line discipline at all,
but instead extend the existing line discipline with this number.
I'm not sure what happens if you need two modules that try to register
the same ldisc number, but I imagine it is not good.
Shouldn't you instead be using the drivers/bluetooth/hci_{ldisc,h4} code?
Arnd
next prev parent reply other threads:[~2010-10-28 12:22 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 10:38 [PATCH 5/9] mfd: Add UART support for the ST-Ericsson CG2900 Par-Gunnar Hjalmdahl
2010-10-22 12:51 ` Alan Cox
2010-10-22 14:54 ` Par-Gunnar Hjalmdahl
2010-10-22 15:33 ` Alan Cox
2010-10-28 10:37 ` Par-Gunnar Hjalmdahl
2010-10-28 12:22 ` Arnd Bergmann [this message]
2010-10-29 11:58 ` Par-Gunnar Hjalmdahl
2010-10-29 12:08 ` Par-Gunnar Hjalmdahl
2010-10-30 0:09 ` Arnd Bergmann
2010-10-29 16:22 ` Alan Cox
2010-10-30 0:01 ` Arnd Bergmann
2010-10-31 12:04 ` Alan Cox
2010-11-05 17:02 ` Par-Gunnar Hjalmdahl
2010-11-05 17:19 ` Alan Cox
2010-11-08 5:24 ` Arnd Bergmann
2010-11-11 14:28 ` Par-Gunnar Hjalmdahl
2010-11-11 14:40 ` Par-Gunnar Hjalmdahl
2010-11-11 15:12 ` Arnd Bergmann
2010-10-29 11:53 ` Par-Gunnar Hjalmdahl
2010-10-29 16:24 ` Alan Cox
2010-12-03 9:16 ` Par-Gunnar Hjalmdahl
2010-12-03 11:42 ` Vitaly Wool
2010-12-06 9:06 ` Par-Gunnar Hjalmdahl
2010-12-06 9:46 ` Vitaly Wool
2010-12-06 12:01 ` Par-Gunnar Hjalmdahl
2010-12-06 12:25 ` Vitaly Wool
2010-12-06 14:49 ` Arnd Bergmann
2010-12-06 14:57 ` Vitaly Wool
2010-12-06 14:06 ` Arnd Bergmann
2010-12-06 14:54 ` Vitaly Wool
2010-12-06 15:15 ` Arnd Bergmann
2010-12-06 15:28 ` Vitaly Wool
2010-12-06 16:54 ` Arnd Bergmann
2010-12-06 21:24 ` Vitaly Wool
2010-12-06 23:07 ` Arnd Bergmann
2010-12-08 7:41 ` Pavan Savoy
2010-12-08 12:21 ` Par-Gunnar Hjalmdahl
2010-12-08 12:51 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201010281422.46687.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=Lukasz.Rymanowski@tieto.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linus.walleij@stericsson.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pghatwork@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).