From: Johan Hedberg <johan.hedberg@gmail.com>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/5] Fix issue when setting limited discoverable mode
Date: Thu, 28 Oct 2010 14:24:01 -0400 [thread overview]
Message-ID: <20101028182401.GA1693@jh-x301> (raw)
In-Reply-To: <1288252859-10337-1-git-send-email-luiz.dentz@gmail.com>
Hi Luiz,
On Thu, Oct 28, 2010, Luiz Augusto von Dentz wrote:
> if (discoverable && adapter->pairable && adapter->discov_timeout > 0 &&
> - adapter->discov_timeout <= 60)
> + adapter->discov_timeout <= 60) {
> + adapter->mode = MODE_LIMITED;
> adapter_set_limited_discoverable(adapter, TRUE);
Wouldn't it make more sense to do the fix to adapter->mode inside the
adapter_set_limited_discoverable function?
Johan
prev parent reply other threads:[~2010-10-28 18:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-28 8:00 [PATCH 1/5] Fix issue when setting limited discoverable mode Luiz Augusto von Dentz
2010-10-28 8:00 ` [PATCH 2/5] Fix not waiting mode change when setting powered property Luiz Augusto von Dentz
2010-10-28 18:28 ` Johan Hedberg
2010-10-28 8:00 ` [PATCH 3/5] Fix setting Discoverable when adapter is down Luiz Augusto von Dentz
2010-10-28 19:00 ` Johan Hedberg
2010-10-28 8:00 ` [PATCH 4/5] Fix not replying when mode is limited discoverable or discoverable Luiz Augusto von Dentz
2010-10-28 8:00 ` [PATCH 5/5] Fix not being able to set discoverable when discoverable timeout is set Luiz Augusto von Dentz
2010-10-28 18:24 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101028182401.GA1693@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).