* [PATCH] Fix status problem after pulling empty call history
@ 2010-11-04 11:58 Rafal Michalski
2010-11-04 18:11 ` Johan Hedberg
0 siblings, 1 reply; 2+ messages in thread
From: Rafal Michalski @ 2010-11-04 11:58 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Rafal Michalski
Problem with "OK" status after pulling phonebook for empty call history
(cch) is fixed by this patch. Previously "OK" status was received even
for empty (as it normally does for non-empty) call history and now
"Not Found" status is received in case when there is no call event.
---
plugins/pbap.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/plugins/pbap.c b/plugins/pbap.c
index 3ea7d6b..a40563c 100644
--- a/plugins/pbap.c
+++ b/plugins/pbap.c
@@ -251,7 +251,7 @@ static void query_result(const char *buffer, size_t bufsize, int vcards,
DBG("");
- if (vcards < 0) {
+ if (vcards <= 0) {
obex_object_set_io_flags(pbap, G_IO_ERR, -ENOENT);
return;
}
--
1.6.3.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix status problem after pulling empty call history
2010-11-04 11:58 [PATCH] Fix status problem after pulling empty call history Rafal Michalski
@ 2010-11-04 18:11 ` Johan Hedberg
0 siblings, 0 replies; 2+ messages in thread
From: Johan Hedberg @ 2010-11-04 18:11 UTC (permalink / raw)
To: Rafal Michalski; +Cc: linux-bluetooth
Hi Rafal,
On Thu, Nov 04, 2010, Rafal Michalski wrote:
> Problem with "OK" status after pulling phonebook for empty call history
> (cch) is fixed by this patch. Previously "OK" status was received even
> for empty (as it normally does for non-empty) call history and now
> "Not Found" status is received in case when there is no call event.
> ---
> plugins/pbap.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Pushed upstream. Thanks.
Johan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-04 18:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-04 11:58 [PATCH] Fix status problem after pulling empty call history Rafal Michalski
2010-11-04 18:11 ` Johan Hedberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).