From: Johan Hedberg <johan.hedberg@gmail.com>
To: Claudio Takahasi <claudio.takahasi@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org, marcel@holtmann.org
Subject: Re: [PATCH] Move gattrib source files to src directory
Date: Fri, 5 Nov 2010 07:06:02 +0200 [thread overview]
Message-ID: <20101105050602.GD25270@jh-x301> (raw)
In-Reply-To: <1288901266-32547-1-git-send-email-claudio.takahasi@openbossa.org>
Hi Claudio,
On Thu, Nov 04, 2010, Claudio Takahasi wrote:
> gattrib related functions will be required during the device creation
> for GATT enabled devices(BR/EDR and LE). Primary service discovery is
> a pre-condition to probe the GATT device driver.
> ---
> Makefile.am | 7 +-
> attrib/att.c | 764 ------------------------------------------------------
> attrib/att.h | 206 ---------------
> attrib/gatt.c | 113 --------
> attrib/gatt.h | 43 ---
> attrib/gattrib.c | 535 --------------------------------------
> attrib/gattrib.h | 72 -----
> src/att.c | 764 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
> src/att.h | 206 +++++++++++++++
> src/gatt.c | 113 ++++++++
> src/gatt.h | 43 +++
> src/gattrib.c | 535 ++++++++++++++++++++++++++++++++++++++
> src/gattrib.h | 72 +++++
> 13 files changed, 1736 insertions(+), 1737 deletions(-)
> delete mode 100644 attrib/att.c
> delete mode 100644 attrib/att.h
> delete mode 100644 attrib/gatt.c
> delete mode 100644 attrib/gatt.h
> delete mode 100644 attrib/gattrib.c
> delete mode 100644 attrib/gattrib.h
> create mode 100644 src/att.c
> create mode 100644 src/att.h
> create mode 100644 src/gatt.c
> create mode 100644 src/gatt.h
> create mode 100644 src/gattrib.c
> create mode 100644 src/gattrib.h
I'll wait a little bit with this one. I agree that the gattrib
funcionality needs to be available within the core daemon, but does that
necessarily mean that the source files for need to be in src? It'd be
good to get some comment from Marcel about this too.
Johan
next prev parent reply other threads:[~2010-11-05 5:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-04 20:07 [PATCH] Move gattrib source files to src directory Claudio Takahasi
2010-11-05 5:06 ` Johan Hedberg [this message]
2010-11-10 5:26 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101105050602.GD25270@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=claudio.takahasi@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox