From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 5 Nov 2010 11:18:09 +0200 From: Johan Hedberg To: Daniel =?iso-8859-1?Q?=D6rstadius?= Cc: linux-bluetooth@vger.kernel.org Subject: Re: [PATCH] Fix add disconnect watch in connecting state Message-ID: <20101105091808.GA31519@jh-x301> References: <20101104181606.GA15745@jh-x301> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 In-Reply-To: Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Daniel, On Fri, Nov 05, 2010, Daniel Örstadius wrote: > On Thu, Nov 4, 2010 at 8:16 PM, Johan Hedberg wrote: > > This doesn't seem quite right to me. Aren't you now adding a disconnect > > callback twice: once for CONNECTING and a second time for CONNECTED? It > > seems like you should only add it when new_state == CONNECTING, right? > > > > Yes, that seems right, attaching updated patch. Thanks. The patch is now in the upstream tree. Johan