From: Johan Hedberg <johan.hedberg@gmail.com>
To: Anderson Lizardo <anderson.lizardo@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org,
Bruna Moreira <bruna.moreira@openbossa.org>
Subject: Re: [PATCH 1/7] Fix invalid memory access when EIR field length is zero
Date: Thu, 11 Nov 2010 11:35:26 +0200 [thread overview]
Message-ID: <20101111093526.GC4132@jh-x301> (raw)
In-Reply-To: <1289411487-6113-1-git-send-email-anderson.lizardo@openbossa.org>
Hi,
On Wed, Nov 10, 2010, Anderson Lizardo wrote:
> - uint8_t *uuid16;
> - uint8_t *uuid32;
> - uint8_t *uuid128;
> + uint8_t *uuid16 = 0;
> + uint8_t *uuid32 = 0;
> + uint8_t *uuid128 = 0;
0 is for integers, NULL for pointers. However, in this case I don't see
why the inialization is needed at all since the rest of the patch seems
to take care of the bug by itself.
Johan
prev parent reply other threads:[~2010-11-11 9:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-10 17:51 [PATCH 1/7] Fix invalid memory access when EIR field length is zero Anderson Lizardo
2010-11-10 17:51 ` [PATCH 2/7] Refactor get_eir_uuids() to get EIR data length parameter Anderson Lizardo
2010-11-11 9:42 ` Johan Hedberg
2010-11-10 17:51 ` [PATCH 3/7] Refactoring adapter_update_found_devices() function Anderson Lizardo
2010-11-11 10:01 ` Johan Hedberg
2010-11-10 17:51 ` [PATCH 4/7] Initial advertising data parsing implementation Anderson Lizardo
2010-11-10 17:51 ` [PATCH 5/7] Advertising data: extract local name Anderson Lizardo
2010-11-10 17:51 ` [PATCH 6/7] Extract service UUIDs from advertising data Anderson Lizardo
2010-11-10 17:51 ` [PATCH 7/7] Emit "DeviceFound" signal for LE devices Anderson Lizardo
2010-11-11 9:35 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101111093526.GC4132@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=anderson.lizardo@openbossa.org \
--cc=bruna.moreira@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox