From: Johan Hedberg <johan.hedberg@nokia.com>
To: Dmitriy Paliy <dmitriy.paliy@nokia.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 2/3] Code clean up: pbap->params = params removed
Date: Thu, 11 Nov 2010 12:26:30 +0200 [thread overview]
Message-ID: <20101111102629.GJ4132@jh-x301> (raw)
In-Reply-To: <1289460972-2971-2-git-send-email-dmitriy.paliy@nokia.com>
Hi Dmitriy,
On Thu, Nov 11, 2010, Dmitriy Paliy wrote:
> pbap->params = params; removed due to the fact that this assignment is
> already used in the same function.
> ---
> plugins/pbap.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/plugins/pbap.c b/plugins/pbap.c
> index 7b9f1ff..af60741 100644
> --- a/plugins/pbap.c
> +++ b/plugins/pbap.c
> @@ -617,7 +617,6 @@ static int pbap_get(struct obex_session *os, obex_object_t *obj,
> if (path == NULL)
> return -EBADR;
>
> - pbap->params = params;
> ret = obex_get_stream_start(os, path);
>
> g_free(path);
Pushed upstream. Thanks.
Johan
next prev parent reply other threads:[~2010-11-11 10:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-11 7:36 [PATCH 1/3] Split up pbap object and pbap session Dmitriy Paliy
2010-11-11 7:36 ` [PATCH 2/3] Code clean up: pbap->params = params removed Dmitriy Paliy
2010-11-11 10:26 ` Johan Hedberg [this message]
2010-11-11 7:36 ` [PATCH 3/3] Code clean up: cache->folder removed Dmitriy Paliy
2010-11-11 10:26 ` Johan Hedberg
2010-11-11 10:25 ` [PATCH 1/3] Split up pbap object and pbap session Johan Hedberg
2010-11-11 12:08 ` [PATCH 0/1 v2] Split up object and session in pbap.c Dmitriy Paliy
2010-11-11 12:08 ` [PATCH 1/1 " Dmitriy Paliy
2010-11-11 15:51 ` [PATCH v3] " Dmitriy Paliy
2010-11-11 20:57 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101111102629.GJ4132@jh-x301 \
--to=johan.hedberg@nokia.com \
--cc=dmitriy.paliy@nokia.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox