From: Johan Hedberg <johan.hedberg@gmail.com>
To: Claudio Takahasi <claudio.takahasi@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Add a new configuration option to disable Low Energy support
Date: Thu, 11 Nov 2010 15:30:19 +0200 [thread overview]
Message-ID: <20101111133018.GA15983@jh-x301> (raw)
In-Reply-To: <AANLkTinhT+sauN0HXPom_53i6FRQWDjeSLeBaneLwAmb@mail.gmail.com>
Hi Claudio,
> > If the option is called "le" it shouldn't affect GATT over BR/EDR, so I
> > think the check in attrib_server_init should only affect the LE socket
> > (or then rename the option to e.g. main.opts.attrib).
>
> It is not affecting GATT over BR/EDR. bt_io_listen for BR/EDR is above
> this checking.
>
> My patch "[PATCH] Fix possible memory leak of the GIOChannel in the
> attribute server" switched the order of the bt_io_listen calls between
> BR/EDR and LE. I forgot to send these patches as patch sequence.
Ok, then it's fine. The patch is now pushed upstram.
Johan
next prev parent reply other threads:[~2010-11-11 13:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-10 21:55 [PATCH] Use reference counting of the device object while discovering services Claudio Takahasi
2010-11-10 21:56 ` [PATCH] Fix possible memory leak of the GIOChannel in the attribute server Claudio Takahasi
2010-11-11 10:09 ` Johan Hedberg
2010-11-10 21:56 ` [PATCH] Add a new configuration option to disable Low Energy support Claudio Takahasi
2010-11-11 9:18 ` Johan Hedberg
2010-11-11 13:20 ` Claudio Takahasi
2010-11-11 13:30 ` Johan Hedberg [this message]
2010-11-11 10:08 ` [PATCH] Use reference counting of the device object while discovering services Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101111133018.GA15983@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=claudio.takahasi@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox