From: Szymon Janc <szymon.janc@tieto.com>
To: Johan Hedberg <johan.hedberg@gmail.com>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCHv3 3/7] Add DBus OOB API documentation.
Date: Wed, 17 Nov 2010 13:49:51 +0100 [thread overview]
Message-ID: <201011171349.51512.szymon.janc@tieto.com> (raw)
In-Reply-To: <20101116163729.GA3854@jh-x301>
Hi Johan,
> > +Service org.bluez
> > +Interface org.bluez.OOB
> > +Object path /org/bluez
>
> I think this should use the same path as the Manager API, which at the
> moment is /
I was following HealthManager way, but I'm fine if you prefer / path.
> > + array{byte} hash, array{byte} randomizer
> > + ReadLocalOobData(object adapter)
>
> Having to pass an adapter path as a parameter seems weird. Wouldn't it
> make more sense to have this method in the Adapter path/interface
> instead? Also, we could toy around with the thought of putting the two
> other methods into the current Manager interface.
It is OK to me to move ReadLocalOobData to adapter path as this is an adapter
related data.
My initial idea was to keep all oob related methods in org.bluez.OOB interface
but I'm not going to insist on it.
--
Szymon Janc
on behalf of ST-Ericsson
next prev parent reply other threads:[~2010-11-17 12:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 15:44 [PATCHv3 0/7] Support for out of band association model Szymon Janc
2010-11-16 15:44 ` [PATCHv3 1/7] Add support for Out of Band (OOB) " Szymon Janc
2010-11-16 16:16 ` Johan Hedberg
2010-11-16 15:44 ` [PATCHv3 2/7] Add DBus OOB plugin Szymon Janc
2010-11-16 16:30 ` Johan Hedberg
2010-11-16 15:44 ` [PATCHv3 3/7] Add DBus OOB API documentation Szymon Janc
2010-11-16 16:37 ` Johan Hedberg
2010-11-17 12:49 ` Szymon Janc [this message]
2010-11-18 10:51 ` Szymon Janc
2010-11-18 13:45 ` Johan Hedberg
2010-11-16 15:44 ` [PATCHv3 4/7] Add simple-oobprovider for testing Szymon Janc
2010-11-16 15:44 ` [PATCHv3 5/7] Add approval request for incoming pairing requests with OOB mechanism Szymon Janc
2010-11-16 16:24 ` Johan Hedberg
2010-11-17 16:03 ` Szymon Janc
2010-11-16 15:44 ` [PATCHv3 6/7] Update DBus OOB API with RequestApproval method Szymon Janc
2010-11-16 15:44 ` [PATCHv3 7/7] simple-agent - add RequestApproval method for OOB pairing Szymon Janc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201011171349.51512.szymon.janc@tieto.com \
--to=szymon.janc@tieto.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox