From: Johan Hedberg <johan.hedberg@gmail.com>
To: Siarhei Siamashka <siarhei.siamashka@gmail.com>
Cc: Keith Mok <ek9852@gmail.com>, linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v3] Add iwmmxt optimization for sbc for pxa series cpu
Date: Thu, 18 Nov 2010 15:31:52 +0200 [thread overview]
Message-ID: <20101118133152.GA5526@jh-x301> (raw)
In-Reply-To: <201011181505.29428.siarhei.siamashka@gmail.com>
Hi Siarhei,
On Thu, Nov 18, 2010, Siarhei Siamashka wrote:
> 1. Make a final patch in such a form that can be pushed to git repository
> without any modifications, it means that you need a clean commit message and
> not just some text intermixed with the parts and quotations of discussion from
> this mailing list.
> 2. "Signed-off-by" header is not needed for the userspace parts of bluez.
> 3. All files must have copyright notices, even a small one like
> 'sbc_primitives_iwmmxt.h'. And probably you should just replicate all the
> copyright notices from the source files with sbc mmx optimizations and add your
> own copyright on top.
>
> Hopefully that should be enough to get your optimizations applied. Thanks.
Yep, those things would be needed before pushing upstream. Thanks for
reminding me about this patch. I had actually forgotten about it.
Johan
next prev parent reply other threads:[~2010-11-18 13:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-11 8:05 [PATCH] Add iwmmxt optimization for sbc for pxa series cpu Keith Mok
2010-11-11 11:46 ` Siarhei Siamashka
2010-11-12 7:35 ` [PATCH v2] " Keith Mok
2010-11-12 13:22 ` Siarhei Siamashka
2010-11-15 2:46 ` [PATCH v3] " Keith Mok
2010-11-15 11:08 ` Siarhei Siamashka
2010-11-18 13:05 ` Siarhei Siamashka
2010-11-18 13:31 ` Johan Hedberg [this message]
2010-11-18 13:33 ` [PATCH] " Keith Mok
2010-11-18 16:53 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101118133152.GA5526@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=ek9852@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=siarhei.siamashka@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).