From: Johan Hedberg <johan.hedberg@gmail.com>
To: Claudio Takahasi <claudio.takahasi@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 2/6] Add Find By Type Value Response encoding/decoding functions
Date: Thu, 18 Nov 2010 16:47:10 +0200 [thread overview]
Message-ID: <20101118144710.GD7811@jh-x301> (raw)
In-Reply-To: <1290017386-23969-2-git-send-email-claudio.takahasi@openbossa.org>
Hi Claudio,
On Wed, Nov 17, 2010, Claudio Takahasi wrote:
> --- a/attrib/att.h
> +++ b/attrib/att.h
> @@ -122,6 +122,11 @@ struct att_data_list {
> uint8_t **data;
> };
>
> +struct range {
> + uint16_t start;
> + uint16_t end;
> +};
> +
Since this is in the public header file it should be prefixed with att_,
right? (which should also apply for all public symbols here). However,
it seems like you're only using the struct internally in att.c so
probably it doesn't even need to be in the public header file?
Johan
next prev parent reply other threads:[~2010-11-18 14:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 18:09 [PATCH 1/6] Implement Find by Type request encode/decoding Claudio Takahasi
2010-11-17 18:09 ` [PATCH 2/6] Add Find By Type Value Response encoding/decoding functions Claudio Takahasi
2010-11-18 14:47 ` Johan Hedberg [this message]
2010-11-18 15:25 ` Claudio Takahasi
2010-11-18 17:48 ` [PATCH v2 " Claudio Takahasi
2010-11-18 20:01 ` Johan Hedberg
2010-11-17 18:09 ` [PATCH 3/6] Implement Find by Type Value Request in the atttribute server Claudio Takahasi
2010-11-18 18:02 ` [PATCH v2 " Claudio Takahasi
2010-11-17 18:09 ` [PATCH 4/6] Extend bt_string2uuid to convert hex strings to UUID16 Claudio Takahasi
2010-11-17 18:09 ` [PATCH 5/6] Add an extra parameter in the discovery primary to specify the UUID Claudio Takahasi
2010-11-17 18:09 ` [PATCH 6/6] Implement Discover Primary Service by Service UUID in the gatttool Claudio Takahasi
2010-11-18 18:07 ` [PATCH v2 " Claudio Takahasi
2010-11-18 14:45 ` [PATCH 1/6] Implement Find by Type request encode/decoding Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101118144710.GD7811@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=claudio.takahasi@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox