From: "Gustavo F. Padovan" <padovan@profusion.mobi>
To: Ville Tervo <ville.tervo@nokia.com>
Cc: ext Vinicius Costa Gomes <vinicius.gomes@openbossa.org>,
linux-bluetooth@vger.kernel.org
Subject: Re: [RFC 00/20] Simple SMP Just Works implementation
Date: Wed, 24 Nov 2010 19:08:48 -0200 [thread overview]
Message-ID: <20101124210848.GC2592@vigoh> (raw)
In-Reply-To: <20101124054211.GI874@null>
Hi Ville,
* Ville Tervo <ville.tervo@nokia.com> [2010-11-24 07:42:11 +0200]:
> Hi,
>
>
> On Tue, Nov 23, 2010 at 12:06:16PM -0300, ext Vinicius Costa Gomes wrote:
> > Hi,
> >
> > This is an implementation of the Just Works SMP procedure, on top of the work
> > done by Ville (included in this series to give some context). The SMP stuff
> > starts at 11/20.
> >
> > The most important thing about this series is the discussion that (I hope)
> > it will cause.
> >
> > Some things that I would like to point (in no order):
> >
> > - the SMP function names follow the spec nomeclature, would it be better to
> > use more meaningful names?
> >
> > - the crypto transform is allocated during the adapter registration, is this
> > the best place to do this?
> >
> > - renaming l2cap.c to l2cap_core.c was the only way we could find to keep the
> > SMP implementation separated from the "core" l2cap.
>
> Gustavo do you have something against this change?
I'm ok with this change.
--
Gustavo F. Padovan
http://profusion.mobi
prev parent reply other threads:[~2010-11-24 21:08 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-23 15:06 [RFC 00/20] Simple SMP Just Works implementation Vinicius Costa Gomes
2010-11-23 15:06 ` [RFC 01/20] Bluetooth: Add low energy commands and events Vinicius Costa Gomes
2010-11-23 15:06 ` [RFC 02/20] Bluetooth: Add LE connect support Vinicius Costa Gomes
2010-11-23 17:57 ` Gustavo F. Padovan
2010-11-24 5:03 ` Ville Tervo
2010-11-23 15:06 ` [RFC 03/20] Bluetooth: Use LE buffers for LE traffic Vinicius Costa Gomes
2010-11-23 15:06 ` [RFC 04/20] Bluetooth: Add LE connection support to L2CAP Vinicius Costa Gomes
2010-11-23 15:06 ` [RFC 05/20] Bluetooth: Add server socket support for LE connection Vinicius Costa Gomes
2010-11-23 15:06 ` [RFC 06/20] Bluetooth: Do not send disconn comand over LE links Vinicius Costa Gomes
2010-11-23 22:48 ` Gustavo F. Padovan
2010-11-24 5:05 ` Ville Tervo
2010-11-23 15:06 ` [RFC 07/20] Bluetooth: Fix initiated LE connections Vinicius Costa Gomes
2010-11-23 15:06 ` [RFC 08/20] Bluetooth: Treat LE and ACL links separately on timeout Vinicius Costa Gomes
2010-11-23 15:06 ` [RFC 09/20] Bluetooth: Fix locking balance in l2cap_le_conn_ready Vinicius Costa Gomes
2010-11-23 22:52 ` Gustavo F. Padovan
2010-11-23 15:06 ` [RFC 10/20] Bluetooth: Add server socket support for LE connection Vinicius Costa Gomes
2010-11-23 22:54 ` Gustavo F. Padovan
2010-11-23 23:04 ` Vinicius Costa Gomes
2010-11-23 15:06 ` [RFC 11/20] Bluetooth: Add SMP command structures Vinicius Costa Gomes
2010-11-23 15:06 ` [RFC 12/20] Bluetooth: fix receiving L2CAP packets over LE Vinicius Costa Gomes
2010-11-23 22:55 ` Gustavo F. Padovan
2010-11-23 23:06 ` Vinicius Costa Gomes
2010-11-24 5:32 ` Ville Tervo
2010-11-24 14:47 ` Vinicius Costa Gomes
2010-11-23 15:06 ` [RFC 13/20] Bluetooth: Implement the first SMP commands Vinicius Costa Gomes
2010-11-23 15:06 ` [RFC 14/20] Bluetooth: Start SMP procedure Vinicius Costa Gomes
2010-11-23 15:06 ` [RFC 15/20] Bluetooth: simple SMP pairing negotiation Vinicius Costa Gomes
2010-11-23 15:06 ` [RFC 16/20] Bluetooth: LE SMP Cryptoolbox functions Vinicius Costa Gomes
2010-11-23 15:06 ` [RFC 17/20] Bluetooth: Add support for using the crypto subsystem Vinicius Costa Gomes
2010-11-23 23:02 ` Gustavo F. Padovan
2010-11-23 15:06 ` [RFC 18/20] Bluetooth: Add support for SMP confirmation checks Vinicius Costa Gomes
2010-11-23 15:06 ` [RFC 19/20] Bluetooth: Add support for LE Start Encryption Vinicius Costa Gomes
2010-11-23 15:06 ` [RFC 20/20] Bluetooth: Add support for resuming socket when SMP is finished Vinicius Costa Gomes
2010-11-24 5:42 ` [RFC 00/20] Simple SMP Just Works implementation Ville Tervo
2010-11-24 21:08 ` Gustavo F. Padovan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101124210848.GC2592@vigoh \
--to=padovan@profusion.mobi \
--cc=linux-bluetooth@vger.kernel.org \
--cc=ville.tervo@nokia.com \
--cc=vinicius.gomes@openbossa.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).