From: Johan Hedberg <johan.hedberg@gmail.com>
To: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 2/3] Bluetooth: Add initial Bluetooth Management interface callbacks
Date: Wed, 24 Nov 2010 23:47:47 +0200 [thread overview]
Message-ID: <20101124214747.GA8626@jh-x301> (raw)
In-Reply-To: <AANLkTik0x3tjnM85Mu=vwU6GB2pXAgWXnqe28aKS+QkN@mail.gmail.com>
Hi Andrei,
On Wed, Nov 24, 2010, Andrei Emeltchenko wrote:
> > - if (haddr->hci_dev != HCI_DEV_NONE) {
> > - if (!(hdev = hci_dev_get(haddr->hci_dev))) {
> > + if (haddr.hci_dev != HCI_DEV_NONE) {
> > + if (!(hdev = hci_dev_get(haddr.hci_dev))) {
>
> doesn't checkpatch give errors here?
Probably, but I've understood that it's ok if it's the existing code
that contains the coding style issue.
> Would be more clean like:
> ...
> hdev = hci_dev_get(haddr.hci_dev);
> if (!hdev)
> ...
>
> At some point shall be fixed in the old code also
Agreed. A separate code cleanup patch would be nice. I've intentionally
kept the old style to not mix coding style and functional changes into
the same patch and to make it clear that I'm not introducing any changes
to the code logic at this place.
Johan
next prev parent reply other threads:[~2010-11-24 21:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-24 14:39 Initial set of Management interface patches johan.hedberg
2010-11-24 14:39 ` [PATCH 1/3] Bluetooth: Add Bluetooth Management interface definitions johan.hedberg
2010-11-24 14:47 ` Marcel Holtmann
2010-11-24 14:39 ` [PATCH 2/3] Bluetooth: Add initial Bluetooth Management interface callbacks johan.hedberg
2010-11-24 14:48 ` Marcel Holtmann
2010-11-24 14:55 ` Andrei Emeltchenko
2010-11-24 21:47 ` Johan Hedberg [this message]
2010-11-24 21:58 ` Gustavo F. Padovan
2010-11-24 15:38 ` Anderson Lizardo
2010-11-24 19:10 ` Gustavo F. Padovan
2010-11-24 14:39 ` [PATCH 3/3] Bluetooth: Make hci_send_to_sock usable for management control sockets johan.hedberg
2010-11-24 14:49 ` Marcel Holtmann
-- strict thread matches above, loose matches on Subject: below --
2010-12-05 18:19 Initial Management interface patches (rebased) johan.hedberg
2010-12-05 18:19 ` [PATCH 2/3] Bluetooth: Add initial Bluetooth Management interface callbacks johan.hedberg
2010-12-06 13:11 ` Anderson Lizardo
2010-12-06 14:21 ` Johan Hedberg
2010-12-06 20:37 ` Gustavo F. Padovan
2010-12-07 22:21 Initial Management patches (rebased again) johan.hedberg
2010-12-07 22:21 ` [PATCH 2/3] Bluetooth: Add initial Bluetooth Management interface callbacks johan.hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101124214747.GA8626@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=andrei.emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).