[PATCH 0/2] Sim Access Prifile API

[PATCH 0/2] Sim Access Prifile API

[Waldemar Rymarkiewicz]

Hi,

I'am posting modified SAP API again in a seperate mail to keep better track of this.
Comments and new ideas will be appreciated.

Thanks,
/Waldek

[PATCH 1/2] Sim Access Profile API

[Waldemar Rymarkiewicz]

New API for Sim Access Profile.
---
 Makefile.am     |    2 +-
 doc/sap-api.txt |   47 +++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 48 insertions(+), 1 deletions(-)
 create mode 100644 doc/sap-api.txt

diff --git a/Makefile.am b/Makefile.am
index 5f96975..97345a3 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -354,7 +354,7 @@ EXTRA_DIST += doc/manager-api.txt \
 		doc/service-api.txt doc/agent-api.txt doc/attribute-api.txt \
 		doc/serial-api.txt doc/network-api.txt \
 		doc/input-api.txt doc/audio-api.txt doc/control-api.txt \
-		doc/hfp-api.txt doc/assigned-numbers.txt
+		doc/hfp-api.txt doc/assigned-numbers.txt doc/sap-api.txt
 
 AM_YFLAGS = -d
 
diff --git a/doc/sap-api.txt b/doc/sap-api.txt
new file mode 100644
index 0000000..4e5626e
--- /dev/null
+++ b/doc/sap-api.txt
@@ -0,0 +1,47 @@
+BlueZ D-Bus Sim Access Profile API description
+***********************************
+
+Copyright (C) 2010 ST-Ericsson SA
+
+
+Sim Access Profile hierarchy
+============================
+
+Service		org.bluez
+Interface	org.bluez.SimAccess
+Object path	[variable prefix]/{hci0,hci1,...}
+
+Methods		void Disconnect()
+
+			Disconnects SAP client from the server.
+
+			Possible errors: org.bluez.Error.Failed
+
+		void SetProperty(string name, variant value)
+
+			Changes the value of the specified property. Only
+			properties that are listed a read-write are changeable.
+
+			Possible Errors: org.bluez.Error.DoesNotExist
+					 org.bluez.Error.InvalidArguments
+
+		dict GetProperties()
+
+			Return all properties for the interface. See the
+			properties section for available properties.
+
+			Possible Errors: org.bluez.Error.Failed
+
+Signals		PropertyChanged(string name, variant value)
+
+			This signal indicates a changed value of the given
+			property.
+
+Properties	boolean Enabled [readwrite]
+
+			Set to true to start-up SAP server and register SDP record for
+			it. Set to false to shutdown SAP server and remove the SDP record.
+
+		boolean Connected [readonly]
+
+			Indicates if SAP client is connected to the server.
-- 
1.7.0.4

Re: [PATCH 1/2] Sim Access Profile API

[Marcel Holtmann]

Hi Waldemar,

> New API for Sim Access Profile.
> ---
>  Makefile.am     |    2 +-
>  doc/sap-api.txt |   47 +++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 48 insertions(+), 1 deletions(-)
>  create mode 100644 doc/sap-api.txt
> 
> diff --git a/Makefile.am b/Makefile.am
> index 5f96975..97345a3 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -354,7 +354,7 @@ EXTRA_DIST += doc/manager-api.txt \
>  		doc/service-api.txt doc/agent-api.txt doc/attribute-api.txt \
>  		doc/serial-api.txt doc/network-api.txt \
>  		doc/input-api.txt doc/audio-api.txt doc/control-api.txt \
> -		doc/hfp-api.txt doc/assigned-numbers.txt
> +		doc/hfp-api.txt doc/assigned-numbers.txt doc/sap-api.txt
>  
>  AM_YFLAGS = -d
>  
> diff --git a/doc/sap-api.txt b/doc/sap-api.txt
> new file mode 100644
> index 0000000..4e5626e
> --- /dev/null
> +++ b/doc/sap-api.txt
> @@ -0,0 +1,47 @@
> +BlueZ D-Bus Sim Access Profile API description
> +***********************************
> +
> +Copyright (C) 2010 ST-Ericsson SA
> +
> +
> +Sim Access Profile hierarchy
> +============================
> +
> +Service		org.bluez
> +Interface	org.bluez.SimAccess
> +Object path	[variable prefix]/{hci0,hci1,...}
> +
> +Methods		void Disconnect()
> +
> +			Disconnects SAP client from the server.
> +
> +			Possible errors: org.bluez.Error.Failed
> +
> +		void SetProperty(string name, variant value)
> +
> +			Changes the value of the specified property. Only
> +			properties that are listed a read-write are changeable.
> +
> +			Possible Errors: org.bluez.Error.DoesNotExist
> +					 org.bluez.Error.InvalidArguments
> +
> +		dict GetProperties()
> +
> +			Return all properties for the interface. See the
> +			properties section for available properties.
> +
> +			Possible Errors: org.bluez.Error.Failed
> +
> +Signals		PropertyChanged(string name, variant value)
> +
> +			This signal indicates a changed value of the given
> +			property.
> +
> +Properties	boolean Enabled [readwrite]
> +
> +			Set to true to start-up SAP server and register SDP record for
> +			it. Set to false to shutdown SAP server and remove the SDP record.

do we want this really as property? Wouldn't be configuration option be
better to enable this. None of the other profiles has this anymore. And
if their server depends on external programs then it either goes via an
agent or some method call that can be easily tracked.

Regards

Marcel

RE: [PATCH 1/2] Sim Access Profile API

[Waldemar.Rymarkiewicz]

Hi Marcel,=20

>From: Marcel Holtmann [mailto:marcel@holtmann.org]=20
>Hi Waldemar,
>
>
>do we want this really as property? Wouldn't be configuration=20
>option be better to enable this. None of the other profiles=20
>has this anymore.=20

Well, that is actually a proposal and I don't see any problems if we go for=
 conf options in here. Even more, that would be if fact more usef-ull.  Is =
the main.conf a right place for say EnableSAP=3Dtrue option ?

>And if their server depends on external=20
>programs then it either goes via an agent or some method call=20
>that can be easily tracked.
>
I'm not sure I get it. Do you mean if an external program needs to enable s=
ap they will use method call?=20

Regards,
/Waldek

Re: [PATCH 1/2] Sim Access Profile API

[Johan Hedberg]

Hi Waldek,

On Wed, Dec 01, 2010, Waldemar.Rymarkiewicz@tieto.com wrote:
> >do we want this really as property? Wouldn't be configuration 
> >option be better to enable this. None of the other profiles 
> >has this anymore. 
> 
> Well, that is actually a proposal and I don't see any problems if we
> go for conf options in here. Even more, that would be if fact more
> usef-ull.  Is the main.conf a right place for say EnableSAP=true
> option ?

If the SAP support is all contained within a single plugin you probably
don't need a new option at all but can simply use the DisablePlugins
option for it.

Johan

RE: [PATCH 1/2] Sim Access Profile API

[Waldemar.Rymarkiewicz]

Hi Johan,=20

>-----Original Message-----
>From: Johan Hedberg [mailto:johan.hedberg@gmail.com]=20
>
>On Wed, Dec 01, 2010, Waldemar.Rymarkiewicz@tieto.com wrote:
>> >do we want this really as property? Wouldn't be=20
>configuration option=20
>> >be better to enable this. None of the other profiles has this=20
>> >anymore.
>>=20
>> Well, that is actually a proposal and I don't see any problems if we=20
>> go for conf options in here. Even more, that would be if fact more=20
>> usef-ull.  Is the main.conf a right place for say EnableSAP=3Dtrue=20
>> option ?
>
>If the SAP support is all contained within a single plugin you=20
>probably don't need a new option at all but can simply use the=20
>DisablePlugins option for it.
>

Ok. I see that.

/Waldek