From: Stefan Seyfried <stefan.seyfried@googlemail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org, gregkh@suse.de,
Stefan Seyfried <seife+kernel@b1-systems.com>,
Oliver Neukum <oneukum@suse.de>,
Gustavo F. Padovan <padovan@profusion.mobi>
Subject: Re: [PATCH] btusb: Fix log spamming due to autosuspend
Date: Wed, 1 Dec 2010 15:47:14 +0100 [thread overview]
Message-ID: <20101201154714.517289f7@susi> (raw)
In-Reply-To: <1291200140.4795.91.camel@aeonflux>
Hi Marcel,
On Wed, 01 Dec 2010 11:42:20 +0100
Marcel Holtmann <marcel@holtmann.org> wrote:
> Hi Stefan,
>
> > If a device is autosuspended an inability to resubmit URBs is
> > to be expected. Check the error code and only log real errors.
> > (Now that autosuspend is default enabled for btusb, those log
> > messages were happening all the time e.g. with a BT mouse)
> >
> > Signed-off-by: Stefan Seyfried <seife+kernel@b1-systems.com>
> > Signed-off-by: Oliver Neukum <oneukum@suse.de>
>
> we had a similar one some time ago, but I am fine with this one as well.
> Actually this one might be a bit better since it still keeps some
> errors.
>
> Acked-by: Marcel Holtmann <marcel@holtmann.org>
Could you (or Gustavo) send it to Linus? It's pretty trivial, but the
messages are annoying and users will complain if they are still in 2.6.37
final.
It will probably have more weight if the maintainer sends it than if I
send it ;)
--
Stefan Seyfried
"Any ideas, John?"
"Well, surrounding them's out."
next prev parent reply other threads:[~2010-12-01 14:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-30 20:49 [PATCH] btusb: Fix log spamming due to autosuspend stefan.seyfried
2010-11-30 21:51 ` Stefan Seyfried
2010-11-30 23:47 ` Greg KH
2010-12-01 10:42 ` Marcel Holtmann
2010-12-01 14:47 ` Stefan Seyfried [this message]
2010-12-01 17:49 ` Gustavo F. Padovan
2010-12-09 19:16 ` Stefan Seyfried
2010-12-13 17:46 ` Gustavo F. Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101201154714.517289f7@susi \
--to=stefan.seyfried@googlemail.com \
--cc=gregkh@suse.de \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=oneukum@suse.de \
--cc=padovan@profusion.mobi \
--cc=seife+kernel@b1-systems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox