[PATCH] btusb: Fix log spamming due to autosuspend

[PATCH] btusb: Fix log spamming due to autosuspend

[stefan.seyfried]

From: Stefan Seyfried <seife+kernel@b1-systems.com>

If a device is autosuspended an inability to resubmit URBs is
to be expected. Check the error code and only log real errors.
(Now that autosuspend is default enabled for btusb, those log
messages were happening all the time e.g. with a BT mouse)

Signed-off-by: Stefan Seyfried <seife+kernel@b1-systems.com>
Signed-off-by: Oliver Neukum <oneukum@suse.de>
---
 drivers/bluetooth/btusb.c |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index ab3894f..d323c1a 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -239,7 +239,8 @@ static void btusb_intr_complete(struct urb *urb)
 
 	err = usb_submit_urb(urb, GFP_ATOMIC);
 	if (err < 0) {
-		BT_ERR("%s urb %p failed to resubmit (%d)",
+		if (err != -EPERM)
+			BT_ERR("%s urb %p failed to resubmit (%d)",
 						hdev->name, urb, -err);
 		usb_unanchor_urb(urb);
 	}
@@ -323,7 +324,8 @@ static void btusb_bulk_complete(struct urb *urb)
 
 	err = usb_submit_urb(urb, GFP_ATOMIC);
 	if (err < 0) {
-		BT_ERR("%s urb %p failed to resubmit (%d)",
+		if (err != -EPERM)
+			BT_ERR("%s urb %p failed to resubmit (%d)",
 						hdev->name, urb, -err);
 		usb_unanchor_urb(urb);
 	}
@@ -412,7 +414,8 @@ static void btusb_isoc_complete(struct urb *urb)
 
 	err = usb_submit_urb(urb, GFP_ATOMIC);
 	if (err < 0) {
-		BT_ERR("%s urb %p failed to resubmit (%d)",
+		if (err != -EPERM)
+			BT_ERR("%s urb %p failed to resubmit (%d)",
 						hdev->name, urb, -err);
 		usb_unanchor_urb(urb);
 	}
-- 
1.7.3.1

Re: [PATCH] btusb: Fix log spamming due to autosuspend

[Stefan Seyfried]

On Tue, 30 Nov 2010 21:49:08 +0100
stefan.seyfried@googlemail.com wrote:

> From: Stefan Seyfried <seife+kernel@b1-systems.com>
> 
> If a device is autosuspended an inability to resubmit URBs is
> to be expected. Check the error code and only log real errors.
> (Now that autosuspend is default enabled for btusb, those log
> messages were happening all the time e.g. with a BT mouse)
> 
> Signed-off-by: Stefan Seyfried <seife+kernel@b1-systems.com>
> Signed-off-by: Oliver Neukum <oneukum@suse.de>

As Greg has told me, this needs to go through the bluetooth Maintainer.
Personally, with 2.6.37 having autosuspend enabled by default I think this
is pretty urgent, as it spams the log continuously when using a Bluetooth
mouse. So please forward this if deemed acceptable.

Thanks
-- 
Stefan Seyfried

"Any ideas, John?"
"Well, surrounding them's out."

Re: [PATCH] btusb: Fix log spamming due to autosuspend

[Greg KH]

On Tue, Nov 30, 2010 at 09:49:08PM +0100, stefan.seyfried@googlemail.com wrote:
> From: Stefan Seyfried <seife+kernel@b1-systems.com>
> 
> If a device is autosuspended an inability to resubmit URBs is
> to be expected. Check the error code and only log real errors.
> (Now that autosuspend is default enabled for btusb, those log
> messages were happening all the time e.g. with a BT mouse)
> 
> Signed-off-by: Stefan Seyfried <seife+kernel@b1-systems.com>
> Signed-off-by: Oliver Neukum <oneukum@suse.de>
> ---
>  drivers/bluetooth/btusb.c |    9 ++++++---

This one doesn't go through me, sorry:

	> ./scripts/get_maintainer.pl --file --roles drivers/bluetooth/btusb.c
	Marcel Holtmann <marcel@holtmann.org> (maintainer:BLUETOOTH DRIVERS)
	"Gustavo F. Padovan" <padovan@profusion.mobi> (maintainer:BLUETOOTH DRIVERS)
	linux-bluetooth@vger.kernel.org (open list:BLUETOOTH DRIVERS)
	linux-kernel@vger.kernel.org (open list)

Marcel and Gustavo are the ones that need to handle it.

thanks,

greg k-h

Re: [PATCH] btusb: Fix log spamming due to autosuspend

[Marcel Holtmann]

Hi Stefan,

> If a device is autosuspended an inability to resubmit URBs is
> to be expected. Check the error code and only log real errors.
> (Now that autosuspend is default enabled for btusb, those log
> messages were happening all the time e.g. with a BT mouse)
> 
> Signed-off-by: Stefan Seyfried <seife+kernel@b1-systems.com>
> Signed-off-by: Oliver Neukum <oneukum@suse.de>

we had a similar one some time ago, but I am fine with this one as well.
Actually this one might be a bit better since it still keeps some
errors.

Acked-by: Marcel Holtmann <marcel@holtmann.org>

Regards

Marcel

Re: [PATCH] btusb: Fix log spamming due to autosuspend

[Stefan Seyfried]

Hi Marcel,

On Wed, 01 Dec 2010 11:42:20 +0100
Marcel Holtmann <marcel@holtmann.org> wrote:

> Hi Stefan,
> 
> > If a device is autosuspended an inability to resubmit URBs is
> > to be expected. Check the error code and only log real errors.
> > (Now that autosuspend is default enabled for btusb, those log
> > messages were happening all the time e.g. with a BT mouse)
> > 
> > Signed-off-by: Stefan Seyfried <seife+kernel@b1-systems.com>
> > Signed-off-by: Oliver Neukum <oneukum@suse.de>
> 
> we had a similar one some time ago, but I am fine with this one as well.
> Actually this one might be a bit better since it still keeps some
> errors.
> 
> Acked-by: Marcel Holtmann <marcel@holtmann.org>

Could you (or Gustavo) send it to Linus? It's pretty trivial, but the
messages are annoying and users will complain if they are still in 2.6.37
final.

It will probably have more weight if the maintainer sends it than if I
send it ;)
-- 
Stefan Seyfried

"Any ideas, John?"
"Well, surrounding them's out."

Re: [PATCH] btusb: Fix log spamming due to autosuspend

[Gustavo F. Padovan]

Hi Stefan,

* Stefan Seyfried <stefan.seyfried@googlemail.com> [2010-12-01 15:47:14 +0100]:

> Hi Marcel,
> 
> On Wed, 01 Dec 2010 11:42:20 +0100
> Marcel Holtmann <marcel@holtmann.org> wrote:
> 
> > Hi Stefan,
> > 
> > > If a device is autosuspended an inability to resubmit URBs is
> > > to be expected. Check the error code and only log real errors.
> > > (Now that autosuspend is default enabled for btusb, those log
> > > messages were happening all the time e.g. with a BT mouse)
> > > 
> > > Signed-off-by: Stefan Seyfried <seife+kernel@b1-systems.com>
> > > Signed-off-by: Oliver Neukum <oneukum@suse.de>
> > 
> > we had a similar one some time ago, but I am fine with this one as well.
> > Actually this one might be a bit better since it still keeps some
> > errors.
> > 
> > Acked-by: Marcel Holtmann <marcel@holtmann.org>
> 
> Could you (or Gustavo) send it to Linus? It's pretty trivial, but the
> messages are annoying and users will complain if they are still in 2.6.37
> final.

I'll send it, applied to bluetooth-2.6 tree. Thanks.

-- 
Gustavo F. Padovan
http://profusion.mobi

Re: [PATCH] btusb: Fix log spamming due to autosuspend

[Stefan Seyfried]

Hi all,

On Wed, 1 Dec 2010 15:49:10 -0200
"Gustavo F. Padovan" <padovan@profusion.mobi> wrote:

> Hi Stefan,
> 
> * Stefan Seyfried <stefan.seyfried@googlemail.com> [2010-12-01 15:47:14 +0100]:

> > > > If a device is autosuspended an inability to resubmit URBs is
> > > > to be expected. Check the error code and only log real errors.
> > > > (Now that autosuspend is default enabled for btusb, those log
> > > > messages were happening all the time e.g. with a BT mouse)
> > > > 
> > > > Signed-off-by: Stefan Seyfried <seife+kernel@b1-systems.com>
> > > > Signed-off-by: Oliver Neukum <oneukum@suse.de>
> > > 
> > > we had a similar one some time ago, but I am fine with this one as well.
> > > Actually this one might be a bit better since it still keeps some
> > > errors.
> > > 
> > > Acked-by: Marcel Holtmann <marcel@holtmann.org>
> > 
> > Could you (or Gustavo) send it to Linus? It's pretty trivial, but the
> > messages are annoying and users will complain if they are still in 2.6.37
> > final.
> 
> I'll send it, applied to bluetooth-2.6 tree. Thanks.

unfortunately, it does not seem to make it into 2.6.37?
-- 
Stefan Seyfried

"Any ideas, John?"
"Well, surrounding them's out."

Re: [PATCH] btusb: Fix log spamming due to autosuspend

[Gustavo F. Padovan]

Hi Stefan,

* Stefan Seyfried <stefan.seyfried@googlemail.com> [2010-12-09 20:16:57 +0100]:

> Hi all,
> 
> On Wed, 1 Dec 2010 15:49:10 -0200
> "Gustavo F. Padovan" <padovan@profusion.mobi> wrote:
> 
> > Hi Stefan,
> > 
> > * Stefan Seyfried <stefan.seyfried@googlemail.com> [2010-12-01 15:47:14 +0100]:
> 
> > > > > If a device is autosuspended an inability to resubmit URBs is
> > > > > to be expected. Check the error code and only log real errors.
> > > > > (Now that autosuspend is default enabled for btusb, those log
> > > > > messages were happening all the time e.g. with a BT mouse)
> > > > > 
> > > > > Signed-off-by: Stefan Seyfried <seife+kernel@b1-systems.com>
> > > > > Signed-off-by: Oliver Neukum <oneukum@suse.de>
> > > > 
> > > > we had a similar one some time ago, but I am fine with this one as well.
> > > > Actually this one might be a bit better since it still keeps some
> > > > errors.
> > > > 
> > > > Acked-by: Marcel Holtmann <marcel@holtmann.org>
> > > 
> > > Could you (or Gustavo) send it to Linus? It's pretty trivial, but the
> > > messages are annoying and users will complain if they are still in 2.6.37
> > > final.
> > 
> > I'll send it, applied to bluetooth-2.6 tree. Thanks.
> 
> unfortunately, it does not seem to make it into 2.6.37?

Patch is in net-2.6 right now. Should go to mainline soon.

-- 
Gustavo F. Padovan
http://profusion.mobi