From: "Gustavo F. Padovan" <padovan@profusion.mobi>
To: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>
Cc: Anderson Lizardo <anderson.lizardo@openbossa.org>,
linux-bluetooth@vger.kernel.org
Subject: Re: [RFC 1/4] Bluetooth: clean up sco code
Date: Wed, 1 Dec 2010 19:16:35 -0200 [thread overview]
Message-ID: <20101201211635.GD16125@vigoh> (raw)
In-Reply-To: <AANLkTikfeMqq-4fTRHwmL81TDnF2=sQsMhL9o7GoEcX2@mail.gmail.com>
Hi Andrei,
* Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com> [2010-12-01 15:44:50 +0200]:
> Hi,
>
> On Fri, Nov 26, 2010 at 6:14 PM, Anderson Lizardo
> <anderson.lizardo@openbossa.org> wrote:
> > Hi Andrei,
> >
> > On Fri, Nov 26, 2010 at 11:22 AM, Emeltchenko Andrei
> > <Andrei.Emeltchenko.news@gmail.com> wrote:
> >> @@ -828,13 +831,14 @@ static void sco_chan_del(struct sock *sk, int err)
> >>
> >> static void sco_conn_ready(struct sco_conn *conn)
> >> {
> >> - struct sock *parent, *sk;
> >> + struct sock *parent;
> >> + struct sock *sk = conn->sk;
> >
> > I wonder if there is a problem with accessing conn->sk here outside
> > the lock protection?
>
> I believe here is a safe access. We just acquire pointer and possible
> protected operations
> are executed inside lock.
Agreed.
--
Gustavo F. Padovan
http://profusion.mobi
next prev parent reply other threads:[~2010-12-01 21:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-26 15:22 [RFC 0/4] Clean up sco, rfcomm and hci code Emeltchenko Andrei
2010-11-26 15:22 ` [RFC 1/4] Bluetooth: clean up sco code Emeltchenko Andrei
2010-11-26 16:14 ` Anderson Lizardo
2010-12-01 13:44 ` Andrei Emeltchenko
2010-12-01 21:16 ` Gustavo F. Padovan [this message]
2010-11-26 15:22 ` [RFC 2/4] Bluetooth: clean up rfcomm code Emeltchenko Andrei
2010-11-30 1:09 ` Gustavo F. Padovan
2010-11-30 8:41 ` Andrei Emeltchenko
2010-11-30 18:22 ` Gustavo F. Padovan
2010-12-01 10:45 ` Marcel Holtmann
2010-12-01 12:20 ` Andrei Emeltchenko
2010-11-26 15:22 ` [RFC 3/4] Bluetooth: clean up l2cap code Emeltchenko Andrei
2010-11-26 15:22 ` [RFC 4/4] Bluetooth: clean up hci code Emeltchenko Andrei
2010-11-26 16:22 ` Anderson Lizardo
2010-11-26 20:03 ` Andrei Emeltchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101201211635.GD16125@vigoh \
--to=padovan@profusion.mobi \
--cc=anderson.lizardo@openbossa.org \
--cc=andrei.emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).