public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Slawomir Bochenski <lkslawek@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Changed obex_service_driver put() signature.
Date: Wed, 8 Dec 2010 17:18:45 +0200	[thread overview]
Message-ID: <20101208151845.GA28588@jh-x301> (raw)
In-Reply-To: <AANLkTikzUraZ9ac5qf9ePG8YKo0Sx0B2YZoKz8HoRTmn@mail.gmail.com>

Hi,

On Wed, Dec 08, 2010, Slawomir Bochenski wrote:
> This API change is needed for implementing Message Access Profile, as
> MAP uses application parameters in puts also (for example
> SetMessageStatus function, see MAP specification, chapter 5.7) and in
> order to access application parameters headers access to obex object
> is required.
> 
> ---
>  plugins/ftp.c           |    3 ++-
>  plugins/opp.c           |    3 ++-
>  plugins/syncevolution.c |    3 ++-
>  src/obex.c              |    2 +-
>  src/service.h           |    3 ++-
>  5 files changed, 9 insertions(+), 5 deletions(-)

The patch looks good, but I can't apply it with git am. I get the
following:

fatal: corrupt patch at line 14
Patch failed at 0001 Changed obex_service_driver put() signature.

Could you try recreating it with git format-patch and resending with git
send-email? Thanks.

Btw, summary line should start with "Change ..." instead of "Changed
..." and it shouldn't end with a .

Johan

      reply	other threads:[~2010-12-08 15:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-08 14:50 [PATCH] Changed obex_service_driver put() signature Slawomir Bochenski
2010-12-08 15:18 ` Johan Hedberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101208151845.GA28588@jh-x301 \
    --to=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=lkslawek@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox