From: Johan Hedberg <johan.hedberg@gmail.com>
To: Lukasz Pawlik <lucas.pawlik@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Fix crash while reading from mapped file
Date: Tue, 14 Dec 2010 17:34:05 +0200 [thread overview]
Message-ID: <20101214153405.GA11741@jh-x301> (raw)
In-Reply-To: <AANLkTi=jaKy=o0MhzV6xRwyk00OxOhk302-DHXM7fEgE@mail.gmail.com>
Hi Lukasz,
On Tue, Dec 14, 2010, Lukasz Pawlik wrote:
> > I also wonder why we didn't use g_strsplit for this, it seems it would
> > actually do the same, there is a little performance impact since we
> > would have to iterate on the vector generated to call the callback
> > while the current code do it in-place.
>
> Marcel, Johan any thoughts about this ? Should we reimplement this
> code using glib functions ?
It'd be nice to get some comments from Marcel since he is the original
author of the textfile.c code. In general I'm not too happy about having
to allocate a duplicate amount of memory for this (which is completely
dependent on the file size), but I do agree that some fix is needed. I'd
also like to make sure that we get a fix upstream before the next BlueZ
release.
Johan
next prev parent reply other threads:[~2010-12-14 15:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-10 13:55 [PATCH] Fix crash while reading from mapped file Rafal Michalski
2010-12-10 17:45 ` Luiz Augusto von Dentz
2010-12-14 15:10 ` Lukasz Pawlik
2010-12-14 15:34 ` Johan Hedberg [this message]
2010-12-14 15:41 ` Bastien Nocera
2010-12-14 18:20 ` Lukasz Pawlik
2010-12-15 18:19 ` Anderson Lizardo
2010-12-16 9:28 ` Luiz Augusto von Dentz
2010-12-17 9:29 ` Luiz Augusto von Dentz
2010-12-17 13:25 ` Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101214153405.GA11741@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=lucas.pawlik@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox