From: Johan Hedberg <johan.hedberg@gmail.com>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Fix sending duplicate speaker/microphone gains to the headset
Date: Thu, 16 Dec 2010 16:33:32 +0200 [thread overview]
Message-ID: <20101216143332.GB13322@jh-x301> (raw)
In-Reply-To: <1292508801-15581-2-git-send-email-luiz.dentz@gmail.com>
Hi Luiz,
On Thu, Dec 16, 2010, Luiz Augusto von Dentz wrote:
> From: Luiz Augusto von Dentz <luiz.dentz-von@nokia.com>
>
> Current code only prevent duplicate D-Bus signals, so in case headset
> changes the volume a client may set the same volume level again which
> would be send as new volume level.
>
> To fix this headset_set_gain now return -EALREADY if nothing has changed
> so code using it can just ignore the change instead of sending to remote
> device.
> ---
> audio/headset.c | 12 ++++++++----
> 1 files changed, 8 insertions(+), 4 deletions(-)
This one has also been pushed upstream. Thanks.
Johan
next prev parent reply other threads:[~2010-12-16 14:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-16 14:13 [PATCH] Fix not calling SetConfiguration on hfp/hsp endpoints before connected Luiz Augusto von Dentz
2010-12-16 14:13 ` [PATCH] Fix sending duplicate speaker/microphone gains to the headset Luiz Augusto von Dentz
2010-12-16 14:33 ` Johan Hedberg [this message]
2010-12-16 14:32 ` [PATCH] Fix not calling SetConfiguration on hfp/hsp endpoints before connected Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101216143332.GB13322@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox