From: Johan Hedberg <johan.hedberg@gmail.com>
To: Vinicius Costa Gomes <vinicius.gomes@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 02/18] Fix memory leaks in the attrib-server
Date: Wed, 22 Dec 2010 13:55:28 +0200 [thread overview]
Message-ID: <20101222115528.GB27483@jh-x301> (raw)
In-Reply-To: <1292966800-6264-3-git-send-email-vinicius.gomes@openbossa.org>
Hi Vinicius,
On Tue, Dec 21, 2010, Vinicius Costa Gomes wrote:
> ---
> src/attrib-server.c | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
Pushed upstream, though isn't the following bit kind of unnecessary. I
don't see how the code could end up there when le_io isn't NULL:
> @@ -803,6 +804,11 @@ failed:
> g_io_channel_unref(l2cap_io);
> l2cap_io = NULL;
>
> + if (le_io) {
> + g_io_channel_unref(le_io);
> + le_io = NULL;
> + }
> +
Johan
next prev parent reply other threads:[~2010-12-22 11:55 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-21 21:26 [PATCH 00/18] Making GATT a first class citizen Vinicius Costa Gomes
2010-12-21 21:26 ` [PATCH 01/18] Fix attrib plugin deregistration Vinicius Costa Gomes
2010-12-22 11:54 ` Johan Hedberg
2010-12-21 21:26 ` [PATCH 02/18] Fix memory leaks in the attrib-server Vinicius Costa Gomes
2010-12-22 11:55 ` Johan Hedberg [this message]
2010-12-21 21:26 ` [PATCH 03/18] Move primary service storage to device.c Vinicius Costa Gomes
2010-12-22 11:57 ` Johan Hedberg
2010-12-22 22:01 ` [PATCH v2 3/18] " Sheldon Demario
2010-12-22 22:41 ` Johan Hedberg
2010-12-21 21:26 ` [PATCH 04/18] Add a way to store the remote device type Vinicius Costa Gomes
2010-12-22 11:58 ` Johan Hedberg
2010-12-21 21:26 ` [PATCH 05/18] Add support for storing the " Vinicius Costa Gomes
2010-12-22 12:00 ` Johan Hedberg
2010-12-21 21:26 ` [PATCH 06/18] Add support for creating devices from stored types Vinicius Costa Gomes
2010-12-21 21:26 ` [PATCH 07/18] Add support for creating devices from stored primary services Vinicius Costa Gomes
2010-12-22 22:50 ` Johan Hedberg
2010-12-23 0:16 ` [PATCH] " Vinicius Costa Gomes
2010-12-23 8:24 ` Johan Hedberg
2010-12-21 21:26 ` [PATCH 08/18] Add a way to retrieve ATT " Vinicius Costa Gomes
2010-12-22 22:52 ` Johan Hedberg
2010-12-23 0:21 ` [PATCH] " Vinicius Costa Gomes
2010-12-23 8:27 ` Johan Hedberg
2010-12-21 21:26 ` [PATCH 09/18] Remove GATT information when the device is removed Vinicius Costa Gomes
2010-12-21 21:26 ` [PATCH 10/18] Add the btd_ prefix to device_add_service Vinicius Costa Gomes
2010-12-21 21:26 ` [PATCH 11/18] Remove duplicated code for discovering GATT services Vinicius Costa Gomes
2010-12-21 21:26 ` [PATCH 12/18] Clean up the primary service DBus registration Vinicius Costa Gomes
2010-12-21 21:26 ` [PATCH 13/18] Add support for making LE connections to GATT client Vinicius Costa Gomes
2010-12-21 22:22 ` Brian Gix
2010-12-21 21:26 ` [PATCH 14/18] Add a Discover method to the GATT Client Vinicius Costa Gomes
2010-12-21 21:26 ` [PATCH 15/18] Remove GetCharacteristics DBus method Vinicius Costa Gomes
2010-12-21 21:26 ` [PATCH 16/18] Add support for adding services to the Services property Vinicius Costa Gomes
2010-12-21 21:26 ` [PATCH 17/18] Add GetProperties method the Service Interface Vinicius Costa Gomes
2010-12-21 21:26 ` [PATCH 18/18] Add a "services" command to test-device Vinicius Costa Gomes
2010-12-23 8:33 ` Johan Hedberg
2010-12-21 22:06 ` [PATCH 00/18] Making GATT a first class citizen Brian Gix
2010-12-21 22:19 ` Vinicius Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101222115528.GB27483@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=vinicius.gomes@openbossa.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox