From: Johan Hedberg <johan.hedberg@gmail.com>
To: Claudio Takahasi <claudio.takahasi@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2 2/2] Moving interactive code of Discover Primary to gatt.c
Date: Sat, 8 Jan 2011 11:08:06 +0200 [thread overview]
Message-ID: <20110108090806.GA14070@jh-x301> (raw)
In-Reply-To: <1294453679-28068-1-git-send-email-claudio.takahasi@openbossa.org>
Hi Claudio,
On Fri, Jan 07, 2011, Claudio Takahasi wrote:
> Initial patch to move the shared code related to Discover All Primary
> Services and Discover Primary Services by UUID to gatt.c.
> ---
> attrib/gatt.c | 165 +++++++++++++++++++++++++++++++++++++--
> attrib/gatt.h | 6 +-
> attrib/gatttool.c | 82 +++----------------
> src/device.c | 59 ++++++++++++--
> src/glib-helper.c | 224 +++-------------------------------------------------
> src/glib-helper.h | 6 --
> 6 files changed, 238 insertions(+), 304 deletions(-)
Thanks for the updated patch. It has now been pushed upstream. One minor
nitpick: please use the form "Move" instead of "Moving" in the summary
line to keep things consistent in the commit history.
Johan
next prev parent reply other threads:[~2011-01-08 9:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 23:00 [PATCH 1/2] Remove unused variable from browse_req structure Claudio Takahasi
2011-01-07 23:00 ` [PATCH 2/2] Moving interactive code of Discover Primary to gatt.c Claudio Takahasi
2011-01-07 23:30 ` Johan Hedberg
2011-01-08 2:27 ` [PATCH v2 " Claudio Takahasi
2011-01-08 9:08 ` Johan Hedberg [this message]
2011-01-07 23:25 ` [PATCH 1/2] Remove unused variable from browse_req structure Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110108090806.GA14070@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=claudio.takahasi@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).