From: "Gustavo F. Padovan" <padovan@profusion.mobi>
To: johan.hedberg@gmail.com
Cc: linux-bluetooth@vger.kernel.org, ville.tervo@nokia.com
Subject: Re: [PATCH 5/5] Bluetooth: Fix race condition with conn->sec_level
Date: Wed, 19 Jan 2011 14:44:44 -0200 [thread overview]
Message-ID: <20110119164444.GC11083@joana> (raw)
In-Reply-To: <1295419012-25717-6-git-send-email-johan.hedberg@gmail.com>
Hi Johan,
* johan.hedberg@gmail.com <johan.hedberg@gmail.com> [2011-01-19 12:06:52 +0530]:
> From: Johan Hedberg <johan.hedberg@nokia.com>
>
> The conn->sec_level value is supposed to represent the current level of
> security that the connection has. However, by assigning to it before
> requesting authentication it will have the wrong value during the
> authentication procedure. To fix this a pending_sec_level variable is
> added which is used to track the desired security level while making
> sure that sec_level always represents the current level of security.
>
> Signed-off-by: Johan Hedberg <johan.hedberg@nokia.com>
> ---
> include/net/bluetooth/hci_core.h | 1 +
> net/bluetooth/hci_conn.c | 8 ++++++--
> net/bluetooth/hci_event.c | 9 +++++----
> 3 files changed, 12 insertions(+), 6 deletions(-)
I rebased my tree and now this patches applies. It is there now. Thanks.
--
Gustavo F. Padovan
http://profusion.mobi
next prev parent reply other threads:[~2011-01-19 16:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 6:36 [PATCH 0/5] Fixes for authentication and security level issues johan.hedberg
2011-01-19 6:36 ` [PATCH 1/5] Revert "Bluetooth: Update sec_level/auth_type for already existing connections" johan.hedberg
2011-01-19 6:49 ` Johan Hedberg
2011-01-19 6:36 ` [PATCH 2/5] Bluetooth: Fix MITM protection requirement preservation johan.hedberg
2011-01-19 6:36 ` [PATCH 3/5] Bluetooth: Create a unified auth_type evaluation function johan.hedberg
2011-01-19 6:36 ` [PATCH 4/5] Bluetooth: Fix authentication request for L2CAP raw sockets johan.hedberg
2011-01-19 16:29 ` Gustavo F. Padovan
2011-01-19 6:36 ` [PATCH 5/5] Bluetooth: Fix race condition with conn->sec_level johan.hedberg
2011-01-19 16:44 ` Gustavo F. Padovan [this message]
2011-01-19 11:24 ` [PATCH 0/5] Fixes for authentication and security level issues Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110119164444.GC11083@joana \
--to=padovan@profusion.mobi \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=ville.tervo@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox