From: Johan Hedberg <johan.hedberg@gmail.com>
To: Brian Gix <bgix@codeaurora.org>
Cc: linux-bluetooth@vger.kernel.org, vinicius.gomes@openbossa.org,
claudio.takahasi@openbossa.org, padovan@profusion.mobi,
rshaffer@codeaurora.org
Subject: Re: [PATCH 1/3] Fix default GATT/ATT MTU sizes
Date: Thu, 20 Jan 2011 15:02:32 +0530 [thread overview]
Message-ID: <20110120093232.GB540@jh-x301> (raw)
In-Reply-To: <1295474453-8495-2-git-send-email-bgix@codeaurora.org>
Hi Brian,
On Wed, Jan 19, 2011, Brian Gix wrote:
> + if (io == le_io)
> + channel->mtu = ATT_DEFAULT_LE_MTU;
> + else
> + channel->mtu = ATT_DEFAULT_L2CAP_MTU;
> +
I don't think that will work. le_io is the server socket and io is the
new client socket. So they will never be one and the same. Did you
actually test this code?
Johan
next prev parent reply other threads:[~2011-01-20 9:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 22:00 [PATCH 0/3] Add READ_BLOB support to attrib-server Brian Gix
2011-01-19 22:00 ` [PATCH 1/3] Fix default GATT/ATT MTU sizes Brian Gix
2011-01-20 9:32 ` Johan Hedberg [this message]
2011-01-19 22:00 ` [PATCH 2/3] Fix Handle range if Pri/Sec Service is Empty Brian Gix
2011-01-20 9:33 ` Johan Hedberg
2011-01-19 22:00 ` [PATCH 3/3] Add READ_BLOB_REQUEST support to attribute server Brian Gix
2011-01-20 9:35 ` Johan Hedberg
2011-01-19 22:05 ` [PATCH 0/3] Add READ_BLOB support to attrib-server Brian Gix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110120093232.GB540@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=bgix@codeaurora.org \
--cc=claudio.takahasi@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=padovan@profusion.mobi \
--cc=rshaffer@codeaurora.org \
--cc=vinicius.gomes@openbossa.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox