From: Johan Hedberg <johan.hedberg@gmail.com>
To: Brian Gix <bgix@codeaurora.org>
Cc: linux-bluetooth@vger.kernel.org, vinicius.gomes@openbossa.org,
claudio.takahasi@openbossa.org, padovan@profusion.mobi
Subject: Re: [PATCH] Fix incoming attrib-server connection MTUs
Date: Fri, 21 Jan 2011 12:20:29 +0530 [thread overview]
Message-ID: <20110121065029.GB1789@jh-x301> (raw)
In-Reply-To: <1295550541-30535-2-git-send-email-bgix@codeaurora.org>
Hi Brian,
On Thu, Jan 20, 2011, Brian Gix wrote:
> It is important for the Attribute Server to be aware of and completely
> fill response packets up to the full MTU when reading long attributes.
> Some remote devices will only request additional (READ_BLOB) data if
> the preceding read sent the maximum amount of data.
>
> Incoming connections are identified as L2CAP or LE by pointers to the
> Service IO channel the incoming connection was recieved on in the
> user_data parameter. L2CAP channels are set to the BR/EDR minimum MTU
> of 48, and LE channels to the LE payload size of 23.
> ---
> attrib/att.h | 3 ++-
> attrib/gatt.c | 28 ++++++++++++++--------------
> src/attrib-server.c | 13 +++++++++----
> 3 files changed, 25 insertions(+), 19 deletions(-)
Thanks for the updated patch. It looks good now and has been pushed
upstream.
Johan
prev parent reply other threads:[~2011-01-21 6:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-20 19:09 [PATCH 0/1] Fix incoming attrib-server connection MTUs Brian Gix
2011-01-20 19:09 ` [PATCH] " Brian Gix
2011-01-21 6:50 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110121065029.GB1789@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=bgix@codeaurora.org \
--cc=claudio.takahasi@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=padovan@profusion.mobi \
--cc=vinicius.gomes@openbossa.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox