From: Johan Hedberg <johan.hedberg@gmail.com>
To: Rafal Michalski <michalski.raf@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/2] Remove unnecessary ordering from single vCard query
Date: Wed, 26 Jan 2011 13:29:18 +0200 [thread overview]
Message-ID: <20110126112917.GA2789@jh-x301> (raw)
In-Reply-To: <1296039665-3948-1-git-send-email-michalski.raf@gmail.com>
Hi Rafal,
On Wed, Jan 26, 2011, Rafal Michalski wrote:
> Previously ordering for query called CONTACTS_QUERY_FROM_URI was applied.
> It is not needed since always only one vCard (with id specified)
> is fetched.
> ---
> plugins/phonebook-tracker.c | 6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
Doesn't compile:
plugins/phonebook.c: In function 'phonebook_get_entry':
plugins/phonebook.c:1928: error: too many arguments for format
make[1]: *** [plugins/phonebook.o] Error 1
Did you forget to compile with ./bootstrap-configure? Never submit
patches without first checking that they compile cleanly this way.
Johan
prev parent reply other threads:[~2011-01-26 11:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-26 11:01 [PATCH 1/2] Remove unnecessary ordering from single vCard query Rafal Michalski
2011-01-26 11:01 ` [PATCH 2/2] Fix fetching non-empty single owner vCard Rafal Michalski
2011-01-26 11:19 ` Luiz Augusto von Dentz
2011-01-26 11:29 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110126112917.GA2789@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=michalski.raf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox