Linux bluetooth development
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@nokia.com>
To: Radoslaw Jablonski <ext-jablonski.radoslaw@nokia.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/3] Add support for notyfying pbap about more parts from backend
Date: Wed, 9 Feb 2011 14:00:28 -0800	[thread overview]
Message-ID: <20110209220028.GC11911@jh-x301> (raw)
In-Reply-To: <1297237127-16286-1-git-send-email-ext-jablonski.radoslaw@nokia.com>

Hi Radek,

On Wed, Feb 09, 2011, Radoslaw Jablonski wrote:
> Added new parameter to phonebook_cb - lastpart variable.
> If backend want to notify that more parts of current
> request will be delivered later, it should use lastpart=FALSE.
> Because of that, PBAP core will 'know' that should not finalize
> request immediately after receiving data and wait for more
> parts to come.
> If result is returned in one part and no more responses part
> will be sent later, then backend should use lastparam=TRUE.
> Previously results of request from backend was always returned
> in one part to PBAP core.
> ---
>  plugins/irmc.c              |    5 +++--
>  plugins/pbap.c              |   10 +++++++---
>  plugins/phonebook-dummy.c   |    4 ++--
>  plugins/phonebook-ebook.c   |    7 ++++---
>  plugins/phonebook-tracker.c |   13 +++++++------
>  plugins/phonebook.h         |    2 +-
>  6 files changed, 24 insertions(+), 17 deletions(-)

It seems these patches depend on your previous ones which weren't ready
for upstream, so I suppose they'll need to be fixed and resent (once
you've done the necessary changes to the first ones).

Johan

      parent reply	other threads:[~2011-02-09 22:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-09  7:38 [PATCH 1/3] Add support for notyfying pbap about more parts from backend Radoslaw Jablonski
2011-02-09  7:38 ` [PATCH 2/3] Introduction of phonebook_pull_read Radoslaw Jablonski
2011-02-09  7:38 ` [PATCH 3/3] Support for multipart response sending from phonebook-tracker Radoslaw Jablonski
2011-02-09 22:00 ` Johan Hedberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110209220028.GC11911@jh-x301 \
    --to=johan.hedberg@nokia.com \
    --cc=ext-jablonski.radoslaw@nokia.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox