[PATCH] Move HealthManager Interface to "/" path

[PATCH] Move HealthManager Interface to "/" path

[Gustavo F. Padovan]

Yeah, this breaks the API, but health is still disabled by default and it
is not a good idea create a new path only for it. So moving it to "/"
---
 doc/health-api.txt    |    2 +-
 health/hdp.c          |    4 ++--
 test/test-health      |    2 +-
 test/test-health-sink |    2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/doc/health-api.txt b/doc/health-api.txt
index 3d0a717..9d5a54d 100644
--- a/doc/health-api.txt
+++ b/doc/health-api.txt
@@ -10,7 +10,7 @@ Health Device Profile hierarchy
 
 Service		org.bluez
 Interface	org.bluez.HealthManager
-Object path	/org/bluez/
+Object path	/
 
 Methods:
 
diff --git a/health/hdp.c b/health/hdp.c
index d4a2a30..e58bd55 100644
--- a/health/hdp.c
+++ b/health/hdp.c
@@ -2171,7 +2171,7 @@ int hdp_manager_start(DBusConnection *conn)
 {
 	DBG("Starting Health manager");
 
-	if (!g_dbus_register_interface(conn, MANAGER_PATH,
+	if (!g_dbus_register_interface(conn, "/",
 					HEALTH_MANAGER,
 					health_manager_methods, NULL, NULL,
 					NULL, manager_path_unregister)) {
@@ -2186,7 +2186,7 @@ int hdp_manager_start(DBusConnection *conn)
 
 void hdp_manager_stop()
 {
-	g_dbus_unregister_interface(connection, MANAGER_PATH, HEALTH_MANAGER);
+	g_dbus_unregister_interface(connection, "/", HEALTH_MANAGER);
 
 	dbus_connection_unref(connection);
 	DBG("Stopped Health manager");
diff --git a/test/test-health b/test/test-health
index 28cc894..7820a24 100755
--- a/test/test-health
+++ b/test/test-health
@@ -47,7 +47,7 @@ def enter_mainloop():
 	finally:
 		print "Exiting, bye"
 
-hdp_manager = dbus.Interface(bus.get_object("org.bluez", "/org/bluez"),
+hdp_manager = dbus.Interface(bus.get_object("org.bluez", "/"),
 						"org.bluez.HealthManager")
 
 role = None
diff --git a/test/test-health-sink b/test/test-health-sink
index cb9d434..50eb74c 100755
--- a/test/test-health-sink
+++ b/test/test-health-sink
@@ -12,7 +12,7 @@ loop = gobject.MainLoop()
 
 bus = dbus.SystemBus()
 
-hdp_manager = dbus.Interface(bus.get_object("org.bluez", "/org/bluez"),
+hdp_manager = dbus.Interface(bus.get_object("org.bluez", "/"),
 						"org.bluez.HealthManager")
 app_path = hdp_manager.CreateApplication({"DataType": dbus.types.UInt16(4103),
 					"Role": "sink"})
-- 
1.7.4

Re: [PATCH] Move HealthManager Interface to "/" path

[Luiz Augusto von Dentz]

Hi,

On Tue, Feb 15, 2011 at 9:31 PM, Gustavo F. Padovan
<padovan@profusion.mobi> wrote:
> Yeah, this breaks the API, but health is still disabled by default and it
> is not a good idea create a new path only for it. So moving it to "/"
> ---
>  doc/health-api.txt    |    2 +-
>  health/hdp.c          |    4 ++--
>  test/test-health      |    2 +-
>  test/test-health-sink |    2 +-
>  4 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/doc/health-api.txt b/doc/health-api.txt
> index 3d0a717..9d5a54d 100644
> --- a/doc/health-api.txt
> +++ b/doc/health-api.txt
> @@ -10,7 +10,7 @@ Health Device Profile hierarchy
>
>  Service                org.bluez
>  Interface      org.bluez.HealthManager
> -Object path    /org/bluez/
> +Object path    /
>
>  Methods:
>
> diff --git a/health/hdp.c b/health/hdp.c
> index d4a2a30..e58bd55 100644
> --- a/health/hdp.c
> +++ b/health/hdp.c
> @@ -2171,7 +2171,7 @@ int hdp_manager_start(DBusConnection *conn)
>  {
>        DBG("Starting Health manager");
>
> -       if (!g_dbus_register_interface(conn, MANAGER_PATH,
> +       if (!g_dbus_register_interface(conn, "/",
>                                        HEALTH_MANAGER,
>                                        health_manager_methods, NULL, NULL,
>                                        NULL, manager_path_unregister)) {
> @@ -2186,7 +2186,7 @@ int hdp_manager_start(DBusConnection *conn)
>
>  void hdp_manager_stop()
>  {
> -       g_dbus_unregister_interface(connection, MANAGER_PATH, HEALTH_MANAGER);
> +       g_dbus_unregister_interface(connection, "/", HEALTH_MANAGER);
>
>        dbus_connection_unref(connection);
>        DBG("Stopped Health manager");
> diff --git a/test/test-health b/test/test-health
> index 28cc894..7820a24 100755
> --- a/test/test-health
> +++ b/test/test-health
> @@ -47,7 +47,7 @@ def enter_mainloop():
>        finally:
>                print "Exiting, bye"
>
> -hdp_manager = dbus.Interface(bus.get_object("org.bluez", "/org/bluez"),
> +hdp_manager = dbus.Interface(bus.get_object("org.bluez", "/"),
>                                                "org.bluez.HealthManager")
>
>  role = None
> diff --git a/test/test-health-sink b/test/test-health-sink
> index cb9d434..50eb74c 100755
> --- a/test/test-health-sink
> +++ b/test/test-health-sink
> @@ -12,7 +12,7 @@ loop = gobject.MainLoop()
>
>  bus = dbus.SystemBus()
>
> -hdp_manager = dbus.Interface(bus.get_object("org.bluez", "/org/bluez"),
> +hdp_manager = dbus.Interface(bus.get_object("org.bluez", "/"),
>                                                "org.bluez.HealthManager")
>  app_path = hdp_manager.CreateApplication({"DataType": dbus.types.UInt16(4103),
>                                        "Role": "sink"})
> --
> 1.7.4

Any reasons why this is not per adapter? This is supposed to be very
similar to Media API which is used in a per adapter fashion.

-- 
Luiz Augusto von Dentz
Computer Engineer

Re: [PATCH] Move HealthManager Interface to "/" path

[Gustavo F. Padovan]

Hi Luiz,

* Luiz Augusto von Dentz <luiz.dentz@gmail.com> [2011-02-15 21:35:20 +0200]:

> Hi,
> 
> On Tue, Feb 15, 2011 at 9:31 PM, Gustavo F. Padovan
> <padovan@profusion.mobi> wrote:
> > Yeah, this breaks the API, but health is still disabled by default and it
> > is not a good idea create a new path only for it. So moving it to "/"
> > ---
> >  doc/health-api.txt    |    2 +-
> >  health/hdp.c          |    4 ++--
> >  test/test-health      |    2 +-
> >  test/test-health-sink |    2 +-
> >  4 files changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/doc/health-api.txt b/doc/health-api.txt
> > index 3d0a717..9d5a54d 100644
> > --- a/doc/health-api.txt
> > +++ b/doc/health-api.txt
> > @@ -10,7 +10,7 @@ Health Device Profile hierarchy
> >
> >  Service                org.bluez
> >  Interface      org.bluez.HealthManager
> > -Object path    /org/bluez/
> > +Object path    /
> >
> >  Methods:
> >
> > diff --git a/health/hdp.c b/health/hdp.c
> > index d4a2a30..e58bd55 100644
> > --- a/health/hdp.c
> > +++ b/health/hdp.c
> > @@ -2171,7 +2171,7 @@ int hdp_manager_start(DBusConnection *conn)
> >  {
> >        DBG("Starting Health manager");
> >
> > -       if (!g_dbus_register_interface(conn, MANAGER_PATH,
> > +       if (!g_dbus_register_interface(conn, "/",
> >                                        HEALTH_MANAGER,
> >                                        health_manager_methods, NULL, NULL,
> >                                        NULL, manager_path_unregister)) {
> > @@ -2186,7 +2186,7 @@ int hdp_manager_start(DBusConnection *conn)
> >
> >  void hdp_manager_stop()
> >  {
> > -       g_dbus_unregister_interface(connection, MANAGER_PATH, HEALTH_MANAGER);
> > +       g_dbus_unregister_interface(connection, "/", HEALTH_MANAGER);
> >
> >        dbus_connection_unref(connection);
> >        DBG("Stopped Health manager");
> > diff --git a/test/test-health b/test/test-health
> > index 28cc894..7820a24 100755
> > --- a/test/test-health
> > +++ b/test/test-health
> > @@ -47,7 +47,7 @@ def enter_mainloop():
> >        finally:
> >                print "Exiting, bye"
> >
> > -hdp_manager = dbus.Interface(bus.get_object("org.bluez", "/org/bluez"),
> > +hdp_manager = dbus.Interface(bus.get_object("org.bluez", "/"),
> >                                                "org.bluez.HealthManager")
> >
> >  role = None
> > diff --git a/test/test-health-sink b/test/test-health-sink
> > index cb9d434..50eb74c 100755
> > --- a/test/test-health-sink
> > +++ b/test/test-health-sink
> > @@ -12,7 +12,7 @@ loop = gobject.MainLoop()
> >
> >  bus = dbus.SystemBus()
> >
> > -hdp_manager = dbus.Interface(bus.get_object("org.bluez", "/org/bluez"),
> > +hdp_manager = dbus.Interface(bus.get_object("org.bluez", "/"),
> >                                                "org.bluez.HealthManager")
> >  app_path = hdp_manager.CreateApplication({"DataType": dbus.types.UInt16(4103),
> >                                        "Role": "sink"})
> > --
> > 1.7.4
> 
> Any reasons why this is not per adapter? This is supposed to be very
> similar to Media API which is used in a per adapter fashion.

IIRC In the first versions of the API Marcel tried to abstract the concept of
adapter and have the API works with Health Applications. But not sure if after

http://www.spinics.net/lists/linux-bluetooth/msg06788.html

this is still valid.

-- 
Gustavo F. Padovan
http://profusion.mobi

Re: [PATCH] Move HealthManager Interface to "/" path

[Gustavo F. Padovan]

* Elvis Pfützenreuter <epx@signove.com> [2011-02-15 17:45:05 -0200]:

> Hi Padovan,
> 
> On Feb 15, 2011, at 5:31 PM, Gustavo F. Padovan wrote:
> 
> > Yeah, this breaks the API, but health is still disabled by default and it
> > is not a good idea create a new path only for it. So moving it to "/"
> > ---
> > doc/health-api.txt    |    2 +-
> > health/hdp.c          |    4 ++--
> > test/test-health      |    2 +-
> > test/test-health-sink |    2 +-
> > 4 files changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/doc/health-api.txt b/doc/health-api.txt
> > index 3d0a717..9d5a54d 100644
> > --- a/doc/health-api.txt
> > +++ b/doc/health-api.txt
> > @@ -10,7 +10,7 @@ Health Device Profile hierarchy
> > 
> > Service		org.bluez
> > Interface	org.bluez.HealthManager
> > -Object path	/org/bluez/
> > +Object path	/
> > 
> > Methods:
> > 
> > diff --git a/health/hdp.c b/health/hdp.c
> > index d4a2a30..e58bd55 100644
> > --- a/health/hdp.c
> > +++ b/health/hdp.c
> > @@ -2171,7 +2171,7 @@ int hdp_manager_start(DBusConnection *conn)
> > {
> > 	DBG("Starting Health manager");
> > 
> > -	if (!g_dbus_register_interface(conn, MANAGER_PATH,
> > +	if (!g_dbus_register_interface(conn, "/",
> 
> I'd rather change macro value instead of removing it. Patch gets smaller. 
> (Or remove the macro definition along with its references.)

Yeah, I forgot to remove the macro definition.

-- 
Gustavo F. Padovan
http://profusion.mobi

Re: [PATCH] Move HealthManager Interface to "/" path

[Jose Antonio Santos Cadenas]

Hi all,

2011/2/15 Gustavo F. Padovan <padovan@profusion.mobi>:
> Hi Luiz,
>
> * Luiz Augusto von Dentz <luiz.dentz@gmail.com> [2011-02-15 21:35:20 +0200]:
>
>> Hi,
>>
>> On Tue, Feb 15, 2011 at 9:31 PM, Gustavo F. Padovan
>> <padovan@profusion.mobi> wrote:
>> > Yeah, this breaks the API, but health is still disabled by default and it
>> > is not a good idea create a new path only for it. So moving it to "/"
>> > ---
>> >  doc/health-api.txt    |    2 +-
>> >  health/hdp.c          |    4 ++--
>> >  test/test-health      |    2 +-
>> >  test/test-health-sink |    2 +-
>> >  4 files changed, 5 insertions(+), 5 deletions(-)
>> >
>> > diff --git a/doc/health-api.txt b/doc/health-api.txt
>> > index 3d0a717..9d5a54d 100644
>> > --- a/doc/health-api.txt
>> > +++ b/doc/health-api.txt
>> > @@ -10,7 +10,7 @@ Health Device Profile hierarchy
>> >
>> >  Service                org.bluez
>> >  Interface      org.bluez.HealthManager
>> > -Object path    /org/bluez/
>> > +Object path    /
>> >
>> >  Methods:
>> >
>> > diff --git a/health/hdp.c b/health/hdp.c
>> > index d4a2a30..e58bd55 100644
>> > --- a/health/hdp.c
>> > +++ b/health/hdp.c
>> > @@ -2171,7 +2171,7 @@ int hdp_manager_start(DBusConnection *conn)
>> >  {
>> >        DBG("Starting Health manager");
>> >
>> > -       if (!g_dbus_register_interface(conn, MANAGER_PATH,
>> > +       if (!g_dbus_register_interface(conn, "/",
>> >                                        HEALTH_MANAGER,
>> >                                        health_manager_methods, NULL, NULL,
>> >                                        NULL, manager_path_unregister)) {
>> > @@ -2186,7 +2186,7 @@ int hdp_manager_start(DBusConnection *conn)
>> >
>> >  void hdp_manager_stop()
>> >  {
>> > -       g_dbus_unregister_interface(connection, MANAGER_PATH, HEALTH_MANAGER);
>> > +       g_dbus_unregister_interface(connection, "/", HEALTH_MANAGER);
>> >
>> >        dbus_connection_unref(connection);
>> >        DBG("Stopped Health manager");
>> > diff --git a/test/test-health b/test/test-health
>> > index 28cc894..7820a24 100755
>> > --- a/test/test-health
>> > +++ b/test/test-health
>> > @@ -47,7 +47,7 @@ def enter_mainloop():
>> >        finally:
>> >                print "Exiting, bye"
>> >
>> > -hdp_manager = dbus.Interface(bus.get_object("org.bluez", "/org/bluez"),
>> > +hdp_manager = dbus.Interface(bus.get_object("org.bluez", "/"),
>> >                                                "org.bluez.HealthManager")
>> >
>> >  role = None
>> > diff --git a/test/test-health-sink b/test/test-health-sink
>> > index cb9d434..50eb74c 100755
>> > --- a/test/test-health-sink
>> > +++ b/test/test-health-sink
>> > @@ -12,7 +12,7 @@ loop = gobject.MainLoop()
>> >
>> >  bus = dbus.SystemBus()
>> >
>> > -hdp_manager = dbus.Interface(bus.get_object("org.bluez", "/org/bluez"),
>> > +hdp_manager = dbus.Interface(bus.get_object("org.bluez", "/"),
>> >                                                "org.bluez.HealthManager")
>> >  app_path = hdp_manager.CreateApplication({"DataType": dbus.types.UInt16(4103),
>> >                                        "Role": "sink"})
>> > --
>> > 1.7.4
>>
>> Any reasons why this is not per adapter? This is supposed to be very
>> similar to Media API which is used in a per adapter fashion.
>
> IIRC In the first versions of the API Marcel tried to abstract the concept of
> adapter and have the API works with Health Applications.

Just what Gustavo said the aim is to be adapter independent, you just
register an application and HDP do all the job for you. This way you
don't have to check if an adapter is removed or if a new adapter is
plugged.

> But not sure if after
>
> http://www.spinics.net/lists/linux-bluetooth/msg06788.html
>
> this is still valid.

I think that this is still valid even after this discussion.

Regards.

>
> --
> Gustavo F. Padovan
> http://profusion.mobi
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Re: [PATCH] Move HealthManager Interface to "/" path

[Jose Antonio Santos Cadenas]

Hi all,

2011/2/15 Gustavo F. Padovan <padovan@profusion.mobi>:
> Yeah, this breaks the API, but health is still disabled by default and it
> is not a good idea create a new path only for it. So moving it to "/"

First I'd like to say that I completely agree with this patch, is
something that I've always thought, but when we sent this patches we
used  the other path because is what we agree when we designed the
API, I think that Marcel said something like that the path for
applications will be changed or something like that, but I is possible
that I misunderstood something. The end of this is that we register
HealthManager in path that I'm not completely agree with.

The problem is that the Health API is being alredy used in some
devices, HDP has been quickly integrated in health systems and I don't
know if changing the API now is a good idea. I've received many emails
asking for the API usage from people that was integrating BlueZ on
their systems in order to be able to use HDP.

Some of the devices that integrate BlueZ are also certified, like this:

http://continuaalliance.org/products/certified-products/texasinstrumentsamdm37xlinuxreferenceplatform.html

But it is possible that BlueZ with HDP is integrated in many other
devices and systems that we don't know. So even thinking that the path
change is a good Idea I disagree with this path because it breaks the
API and it's being already in use.

Regards

> ---
>  doc/health-api.txt    |    2 +-
>  health/hdp.c          |    4 ++--
>  test/test-health      |    2 +-
>  test/test-health-sink |    2 +-
>  4 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/doc/health-api.txt b/doc/health-api.txt
> index 3d0a717..9d5a54d 100644
> --- a/doc/health-api.txt
> +++ b/doc/health-api.txt
> @@ -10,7 +10,7 @@ Health Device Profile hierarchy
>
>  Service                org.bluez
>  Interface      org.bluez.HealthManager
> -Object path    /org/bluez/
> +Object path    /
>
>  Methods:
>
> diff --git a/health/hdp.c b/health/hdp.c
> index d4a2a30..e58bd55 100644
> --- a/health/hdp.c
> +++ b/health/hdp.c
> @@ -2171,7 +2171,7 @@ int hdp_manager_start(DBusConnection *conn)
>  {
>        DBG("Starting Health manager");
>
> -       if (!g_dbus_register_interface(conn, MANAGER_PATH,
> +       if (!g_dbus_register_interface(conn, "/",
>                                        HEALTH_MANAGER,
>                                        health_manager_methods, NULL, NULL,
>                                        NULL, manager_path_unregister)) {
> @@ -2186,7 +2186,7 @@ int hdp_manager_start(DBusConnection *conn)
>
>  void hdp_manager_stop()
>  {
> -       g_dbus_unregister_interface(connection, MANAGER_PATH, HEALTH_MANAGER);
> +       g_dbus_unregister_interface(connection, "/", HEALTH_MANAGER);
>
>        dbus_connection_unref(connection);
>        DBG("Stopped Health manager");
> diff --git a/test/test-health b/test/test-health
> index 28cc894..7820a24 100755
> --- a/test/test-health
> +++ b/test/test-health
> @@ -47,7 +47,7 @@ def enter_mainloop():
>        finally:
>                print "Exiting, bye"
>
> -hdp_manager = dbus.Interface(bus.get_object("org.bluez", "/org/bluez"),
> +hdp_manager = dbus.Interface(bus.get_object("org.bluez", "/"),
>                                                "org.bluez.HealthManager")
>
>  role = None
> diff --git a/test/test-health-sink b/test/test-health-sink
> index cb9d434..50eb74c 100755
> --- a/test/test-health-sink
> +++ b/test/test-health-sink
> @@ -12,7 +12,7 @@ loop = gobject.MainLoop()
>
>  bus = dbus.SystemBus()
>
> -hdp_manager = dbus.Interface(bus.get_object("org.bluez", "/org/bluez"),
> +hdp_manager = dbus.Interface(bus.get_object("org.bluez", "/"),
>                                                "org.bluez.HealthManager")
>  app_path = hdp_manager.CreateApplication({"DataType": dbus.types.UInt16(4103),
>                                        "Role": "sink"})
> --
> 1.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Re: [PATCH] Move HealthManager Interface to "/" path

[Jose Antonio Santos Cadenas]

2011/2/16 Jose Antonio Santos Cadenas <santoscadenas@gmail.com>:
> Hi all,
>
> 2011/2/15 Gustavo F. Padovan <padovan@profusion.mobi>:
>> Yeah, this breaks the API, but health is still disabled by default and it
>> is not a good idea create a new path only for it. So moving it to "/"
>
> First I'd like to say that I completely agree with this patch, is
> something that I've always thought, but when we sent this patches we
> used  the other path because is what we agree when we designed the
> API, I think that Marcel said something like that the path for
> applications

Sorry, I mean the path of the Manager

> will be changed or something like that, but I is possible
> that I misunderstood something. The end of this is that we register
> HealthManager in path that I'm not completely agree with.
>
> The problem is that the Health API is being alredy used in some
> devices, HDP has been quickly integrated in health systems and I don't
> know if changing the API now is a good idea. I've received many emails
> asking for the API usage from people that was integrating BlueZ on
> their systems in order to be able to use HDP.
>
> Some of the devices that integrate BlueZ are also certified, like this:
>
> http://continuaalliance.org/products/certified-products/texasinstrumentsamdm37xlinuxreferenceplatform.html
>
> But it is possible that BlueZ with HDP is integrated in many other
> devices and systems that we don't know. So even thinking that the path
> change is a good Idea I disagree with this path because it breaks the
> API and it's being already in use.
>
> Regards
>
>> ---
>>  doc/health-api.txt    |    2 +-
>>  health/hdp.c          |    4 ++--
>>  test/test-health      |    2 +-
>>  test/test-health-sink |    2 +-
>>  4 files changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/doc/health-api.txt b/doc/health-api.txt
>> index 3d0a717..9d5a54d 100644
>> --- a/doc/health-api.txt
>> +++ b/doc/health-api.txt
>> @@ -10,7 +10,7 @@ Health Device Profile hierarchy
>>
>>  Service                org.bluez
>>  Interface      org.bluez.HealthManager
>> -Object path    /org/bluez/
>> +Object path    /
>>
>>  Methods:
>>
>> diff --git a/health/hdp.c b/health/hdp.c
>> index d4a2a30..e58bd55 100644
>> --- a/health/hdp.c
>> +++ b/health/hdp.c
>> @@ -2171,7 +2171,7 @@ int hdp_manager_start(DBusConnection *conn)
>>  {
>>        DBG("Starting Health manager");
>>
>> -       if (!g_dbus_register_interface(conn, MANAGER_PATH,
>> +       if (!g_dbus_register_interface(conn, "/",
>>                                        HEALTH_MANAGER,
>>                                        health_manager_methods, NULL, NULL,
>>                                        NULL, manager_path_unregister)) {
>> @@ -2186,7 +2186,7 @@ int hdp_manager_start(DBusConnection *conn)
>>
>>  void hdp_manager_stop()
>>  {
>> -       g_dbus_unregister_interface(connection, MANAGER_PATH, HEALTH_MANAGER);
>> +       g_dbus_unregister_interface(connection, "/", HEALTH_MANAGER);
>>
>>        dbus_connection_unref(connection);
>>        DBG("Stopped Health manager");
>> diff --git a/test/test-health b/test/test-health
>> index 28cc894..7820a24 100755
>> --- a/test/test-health
>> +++ b/test/test-health
>> @@ -47,7 +47,7 @@ def enter_mainloop():
>>        finally:
>>                print "Exiting, bye"
>>
>> -hdp_manager = dbus.Interface(bus.get_object("org.bluez", "/org/bluez"),
>> +hdp_manager = dbus.Interface(bus.get_object("org.bluez", "/"),
>>                                                "org.bluez.HealthManager")
>>
>>  role = None
>> diff --git a/test/test-health-sink b/test/test-health-sink
>> index cb9d434..50eb74c 100755
>> --- a/test/test-health-sink
>> +++ b/test/test-health-sink
>> @@ -12,7 +12,7 @@ loop = gobject.MainLoop()
>>
>>  bus = dbus.SystemBus()
>>
>> -hdp_manager = dbus.Interface(bus.get_object("org.bluez", "/org/bluez"),
>> +hdp_manager = dbus.Interface(bus.get_object("org.bluez", "/"),
>>                                                "org.bluez.HealthManager")
>>  app_path = hdp_manager.CreateApplication({"DataType": dbus.types.UInt16(4103),
>>                                        "Role": "sink"})
>> --
>> 1.7.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>