From: "Gustavo F. Padovan" <padovan@profusion.mobi>
To: Szymon Janc <szymon.janc@tieto.com>
Cc: linux-bluetooth@vger.kernel.org,
par-gunnar.p.hjalmdahl@stericsson.com,
henrik.possung@stericsson.com
Subject: Re: [PATCH 07/10] Bluetooth: Fix code style issues and make checkpatch silent about hci_core.h
Date: Thu, 17 Feb 2011 11:43:40 -0300 [thread overview]
Message-ID: <20110217144340.GE10543@joana> (raw)
In-Reply-To: <1297948601-12723-8-git-send-email-szymon.janc@tieto.com>
Hi Szymon,
* Szymon Janc <szymon.janc@tieto.com> [2011-02-17 14:16:38 +0100]:
> Signed-off-by: Szymon Janc <szymon.janc@tieto.com>
> ---
> include/net/bluetooth/hci_core.h | 91 +++++++++++++++++++++-----------------
> 1 files changed, 51 insertions(+), 40 deletions(-)
>
> diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h
> index e4f370f..a8a5ecb 100644
> --- a/include/net/bluetooth/hci_core.h
> +++ b/include/net/bluetooth/hci_core.h
> @@ -208,37 +208,37 @@ struct hci_dev {
> struct hci_conn {
> struct list_head list;
>
> - atomic_t refcnt;
> - spinlock_t lock;
> -
> - bdaddr_t dst;
> - __u16 handle;
> - __u16 state;
> - __u8 mode;
> - __u8 type;
> - __u8 out;
> - __u8 attempt;
> - __u8 dev_class[3];
> - __u8 features[8];
> - __u8 ssp_mode;
> - __u16 interval;
> - __u16 pkt_type;
> - __u16 link_policy;
> - __u32 link_mode;
> - __u8 auth_type;
> - __u8 sec_level;
> - __u8 pending_sec_level;
> - __u8 pin_length;
> - __u8 io_capability;
> - __u8 power_save;
> - __u16 disc_timeout;
> - unsigned long pend;
> + atomic_t refcnt;
> + spinlock_t lock;
> +
> + bdaddr_t dst;
> + __u16 handle;
> + __u16 state;
> + __u8 mode;
> + __u8 type;
> + __u8 out;
> + __u8 attempt;
> + __u8 dev_class[3];
> + __u8 features[8];
> + __u8 ssp_mode;
> + __u16 interval;
> + __u16 pkt_type;
> + __u16 link_policy;
> + __u32 link_mode;
> + __u8 auth_type;
> + __u8 sec_level;
> + __u8 pending_sec_level;
> + __u8 pin_length;
> + __u8 io_capability;
> + __u8 power_save;
> + __u16 disc_timeout;
> + unsigned long pend;
>
> __u8 remote_cap;
> __u8 remote_oob;
> __u8 remote_auth;
>
> - unsigned int sent;
> + unsigned int sent;
>
> struct sk_buff_head data_q;
>
> @@ -298,7 +298,8 @@ static inline long inquiry_entry_age(struct inquiry_entry *e)
> return jiffies - e->timestamp;
> }
>
> -struct inquiry_entry *hci_inquiry_cache_lookup(struct hci_dev *hdev, bdaddr_t *bdaddr);
> +struct inquiry_entry *hci_inquiry_cache_lookup(struct hci_dev *hdev,
> + bdaddr_t *bdaddr);
Leave the line over 80 fix out of this patches, I'm not sure if I want to fix
that now.
--
Gustavo F. Padovan
http://profusion.mobi
next prev parent reply other threads:[~2011-02-17 14:43 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-17 13:16 [PATCH 00/10] Support for OOB in mgmt interface Szymon Janc
2011-02-17 13:16 ` [PATCH 01/10] Bluetooth: Use #include <linux/uaccess.h> instead of <asm/uaccess.h> Szymon Janc
2011-02-17 14:29 ` Gustavo F. Padovan
2011-02-17 13:16 ` [PATCH 02/10] Bluetooth: Clean up hci_sniff_subrate_evt function Szymon Janc
2011-02-17 14:30 ` Gustavo F. Padovan
2011-02-17 13:16 ` [PATCH 03/10] Bluetooth: Add optional data parameter to mgmt_ev_cmd_status event Szymon Janc
2011-02-17 13:16 ` [PATCH 04/10] Bluetooth: Use EIO code to report HCI error to userpace Szymon Janc
2011-02-17 13:49 ` Ville Tervo
2011-02-17 14:23 ` Szymon Janc
2011-02-18 7:34 ` Ville Tervo
2011-02-18 9:15 ` [PATCH v2] " Szymon Janc
2011-02-17 13:16 ` [PATCH 05/10] Bluetooth: Add read_local_oob_data management command Szymon Janc
2011-02-17 13:16 ` [PATCH 06/10] Bluetooth: Add add/remove_remote_oob_data management commands Szymon Janc
2011-02-18 11:12 ` [PATCH v2 1/2] " Szymon Janc
2011-02-18 11:12 ` [PATCH v2 2/2] Bluetooth: Enable support for Out of Band authentication Szymon Janc
2011-02-17 13:16 ` [PATCH 07/10] Bluetooth: Fix code style issues and make checkpatch silent about hci_core.h Szymon Janc
2011-02-17 14:43 ` Gustavo F. Padovan [this message]
2011-02-17 15:42 ` [PATCH v2] Bluetooth: Fix some code style issues in hci_core.h Szymon Janc
2011-02-17 16:30 ` Gustavo F. Padovan
2011-02-17 13:16 ` [PATCH 08/10] Bluetooth: Fix code style issues and make checkpatch silent about hci_core.c Szymon Janc
2011-02-17 15:46 ` [PATCH v2] Bluetooth: Fix some code style issues in hci_core.c Szymon Janc
2011-02-17 16:32 ` Gustavo F. Padovan
2011-02-17 13:16 ` [PATCH 09/10] Bluetooth: Fix code style issues, make checkpatch less noisy about hci_event.c Szymon Janc
2011-02-17 15:44 ` [PATCH v2] Bluetooth: Fix some code style issues in hci_event.c Szymon Janc
2011-02-17 16:35 ` Gustavo F. Padovan
2011-02-17 13:16 ` [PATCH 10/10] Bluetooth: Log command and status parameters in command status event Szymon Janc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110217144340.GE10543@joana \
--to=padovan@profusion.mobi \
--cc=henrik.possung@stericsson.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=par-gunnar.p.hjalmdahl@stericsson.com \
--cc=szymon.janc@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox