From: Johan Hedberg <johan.hedberg@gmail.com>
To: David Herrmann <dh.herrmann@googlemail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: PATCH [2/2] batostr(): Replace batostr() where possible with ba2str to avoid memleaks
Date: Thu, 17 Feb 2011 16:05:33 -0300 [thread overview]
Message-ID: <20110217190533.GB22042@jh-x301> (raw)
In-Reply-To: <AANLkTimfR_dhOE-k5c3zJ1+dwMwOCBqq-Y6Df-=rp8FP@mail.gmail.com>
Hi David,
On Wed, Feb 16, 2011, David Herrmann wrote:
> batostr() returns a dynamically allocated string which must be freed
> later, although, the function looks like the standard berkeley socket
> functions that work on static buffers. Two functions inside bluez
> incorrectly use batostr() and do not free the returned pointer. I
> replaced the occurrence of batostr() with a ba2str().
This patch looks good, but you've managed to format it in such away that
I can't feed it directly to git am. Could you try resending with git
send-email?
Johan
prev parent reply other threads:[~2011-02-17 19:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-16 13:12 PATCH [2/2] batostr(): Replace batostr() where possible with ba2str to avoid memleaks David Herrmann
2011-02-17 19:05 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110217190533.GB22042@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=dh.herrmann@googlemail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox