From: Johan Hedberg <johan.hedberg@gmail.com>
To: Brian Gix <bgix@codeaurora.org>
Cc: linux-bluetooth@vger.kernel.org, padovan@profusion.mobi,
anderson.lizardo@openbossa.org
Subject: Re: [PATCH 2/2] Fix bugs found at UPF38 - Las Vegas
Date: Sat, 19 Feb 2011 12:18:33 -0300 [thread overview]
Message-ID: <20110219151833.GB18898@jh-x301> (raw)
In-Reply-To: <1298072261-7232-3-git-send-email-bgix@codeaurora.org>
Hi Brian,
On Fri, Feb 18, 2011, Brian Gix wrote:
> Example Included Service Attribute missing UUID16 field.
> MTU Exchange not bounded by actual size required not to crash.
> ---
> attrib/example.c | 3 ++-
> src/attrib-server.c | 2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)
Even though these are some quite trivial changes, you essentially have
to independent fixes here and they should therefore be in two separate
patches. Also make sure that the summary line of each patch gives at
least some idea of what is being fixed. The way you formulated it now
just tells us that "something" found at UPF38 was fixed.
Johan
P.S. I think you can stop adding extra people to CC in your patch
submissions. --to linux-bluetooth@vger.kernel.org should be enough.
prev parent reply other threads:[~2011-02-19 15:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-18 23:37 [PATCH 0/2 rev3] SDP registrations and UPF bug fixes Brian Gix
2011-02-18 23:37 ` [PATCH 1/2] Add SDP registration of Primary GATT services Brian Gix
2011-02-19 15:14 ` Johan Hedberg
2011-02-18 23:37 ` [PATCH 2/2] Fix bugs found at UPF38 - Las Vegas Brian Gix
2011-02-19 15:18 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110219151833.GB18898@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=anderson.lizardo@openbossa.org \
--cc=bgix@codeaurora.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=padovan@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox