* [PATCH 1/2] Bluetooth: Fix LE conn creation
@ 2011-02-21 18:09 anderson.briglia
2011-02-21 21:00 ` Gustavo F. Padovan
0 siblings, 1 reply; 2+ messages in thread
From: anderson.briglia @ 2011-02-21 18:09 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Anderson Briglia, Ville Tervo
From: Anderson Briglia <anderson.briglia@openbossa.org>
This patch prevents a crash when remote host tries to create a LE
link which already exists. i.e.: call l2test twice passing the
same parameters.
Signed-off-by: Anderson Briglia <anderson.briglia@openbossa.org>
Signed-off-by: Ville Tervo <ville.tervo@nokia.com>
---
net/bluetooth/hci_conn.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
index a050a69..d401775 100644
--- a/net/bluetooth/hci_conn.c
+++ b/net/bluetooth/hci_conn.c
@@ -429,8 +429,9 @@ struct hci_conn *hci_connect(struct hci_dev *hdev, int type, bdaddr_t *dst, __u8
if (type == LE_LINK) {
le = hci_conn_hash_lookup_ba(hdev, LE_LINK, dst);
- if (!le)
- le = hci_conn_add(hdev, LE_LINK, dst);
+ if (le)
+ return NULL;
+ le = hci_conn_add(hdev, LE_LINK, dst);
if (!le)
return NULL;
if (le->state == BT_OPEN)
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] Bluetooth: Fix LE conn creation
2011-02-21 18:09 [PATCH 1/2] Bluetooth: Fix LE conn creation anderson.briglia
@ 2011-02-21 21:00 ` Gustavo F. Padovan
0 siblings, 0 replies; 2+ messages in thread
From: Gustavo F. Padovan @ 2011-02-21 21:00 UTC (permalink / raw)
To: anderson.briglia; +Cc: linux-bluetooth, Ville Tervo
Hi Briglia,
* anderson.briglia@openbossa.org <anderson.briglia@openbossa.org> [2011-02-21 15:09:23 -0300]:
> From: Anderson Briglia <anderson.briglia@openbossa.org>
>
> This patch prevents a crash when remote host tries to create a LE
> link which already exists. i.e.: call l2test twice passing the
> same parameters.
>
> Signed-off-by: Anderson Briglia <anderson.briglia@openbossa.org>
> Signed-off-by: Ville Tervo <ville.tervo@nokia.com>
> ---
> net/bluetooth/hci_conn.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
Applied, thanks.
--
Gustavo F. Padovan
http://profusion.mobi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-02-21 21:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-21 18:09 [PATCH 1/2] Bluetooth: Fix LE conn creation anderson.briglia
2011-02-21 21:00 ` Gustavo F. Padovan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).