* [PATCH] bluetooth: remove unnecessary call to hci_sock_cleanup
@ 2011-02-22 7:13 Anand Gadiyar
2011-02-22 12:26 ` Gustavo F. Padovan
0 siblings, 1 reply; 2+ messages in thread
From: Anand Gadiyar @ 2011-02-22 7:13 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Anand Gadiyar, Gustavo F. Padovan
hci_sock_cleanup is already called after the sock_err label.
It appears that we can drop this call.
Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
Cc: Gustavo F. Padovan <padovan@profusion.mobi>
---
net/bluetooth/af_bluetooth.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
Index: linux-omap-usb/net/bluetooth/af_bluetooth.c
===================================================================
--- linux-omap-usb.orig/net/bluetooth/af_bluetooth.c
+++ linux-omap-usb/net/bluetooth/af_bluetooth.c
@@ -550,10 +550,8 @@ static int __init bt_init(void)
goto error;
err = l2cap_init();
- if (err < 0) {
- hci_sock_cleanup();
+ if (err < 0)
goto sock_err;
- }
err = sco_init();
if (err < 0) {
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] bluetooth: remove unnecessary call to hci_sock_cleanup
2011-02-22 7:13 [PATCH] bluetooth: remove unnecessary call to hci_sock_cleanup Anand Gadiyar
@ 2011-02-22 12:26 ` Gustavo F. Padovan
0 siblings, 0 replies; 2+ messages in thread
From: Gustavo F. Padovan @ 2011-02-22 12:26 UTC (permalink / raw)
To: Anand Gadiyar; +Cc: linux-bluetooth
Hi Anand,
* Anand Gadiyar <gadiyar@ti.com> [2011-02-22 12:43:26 +0530]:
> hci_sock_cleanup is already called after the sock_err label.
> It appears that we can drop this call.
>
> Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
> Cc: Gustavo F. Padovan <padovan@profusion.mobi>
> ---
> net/bluetooth/af_bluetooth.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Also applied, thanks.
--
Gustavo F. Padovan
http://profusion.mobi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-02-22 12:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-22 7:13 [PATCH] bluetooth: remove unnecessary call to hci_sock_cleanup Anand Gadiyar
2011-02-22 12:26 ` Gustavo F. Padovan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).