From: Szymon Janc <szymon.janc@tieto.com>
To: Anderson Lizardo <anderson.lizardo@openbossa.org>
Cc: "linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>,
"par-gunnar.p.hjalmdahl@stericsson.com"
<par-gunnar.p.hjalmdahl@stericsson.com>,
"henrik.possung@stericsson.com" <henrik.possung@stericsson.com>
Subject: Re: [PATCH 2/3] Bluetooth: Move index to common header in management interface
Date: Wed, 23 Feb 2011 14:37:10 +0100 [thread overview]
Message-ID: <201102231437.10401.szymon.janc@tieto.com> (raw)
In-Reply-To: <AANLkTin=5B6E26nzSkGad0W7FfTc+3S0_7F7ErsBLbbp@mail.gmail.com>
> > - err = cmd_complete(sk, MGMT_OP_ADD_UUID, &dev_id, sizeof(dev_id));
> > + err = cmd_complete(sk, index, MGMT_OP_ADD_UUID, &index, sizeof(index));
>
> Is index still required to be passed as return parameter, now that it
> is part of the header? This is the case for various other commands.
I've missed that, should be cmd_complete(sk, index, MGMT_OP_ADD_UUID, NULL, 0);
Will send fixed version.
> > - err = cmd_complete(sk, MGMT_OP_REMOVE_UUID, &dev_id, sizeof(dev_id));
> > + err = cmd_complete(sk, index, MGMT_OP_REMOVE_UUID, NULL, 0);
>
> Here controller index is not being passed as return parameter anymore,
> so it looks inconsistent to me.
This one is correct.
> In general, I think all commands which used to have controller index
> as parameters (both cp and rp), would need to be modified because
> index is already part of the header.
Actually all commands were modified, just missed to null parameters.
> Also be sure to update doc/mgmt-api.txt from BlueZ.
Sure.
> Regards,
>
BR
Szymon
next prev parent reply other threads:[~2011-02-23 13:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 10:26 [PATCH 1/3] Bluetooth: Use proper command structure in remove_uuid Szymon Janc
2011-02-23 10:26 ` [PATCH 2/3] Bluetooth: Move index to common header in management interface Szymon Janc
2011-02-23 13:14 ` Anderson Lizardo
2011-02-23 13:37 ` Szymon Janc [this message]
2011-02-23 13:49 ` Anderson Lizardo
2011-02-23 10:26 ` [PATCH 3/3] Bluetooth: Validate data size before accessing mgmt commands Szymon Janc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102231437.10401.szymon.janc@tieto.com \
--to=szymon.janc@tieto.com \
--cc=anderson.lizardo@openbossa.org \
--cc=henrik.possung@stericsson.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=par-gunnar.p.hjalmdahl@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox