From: Johan Hedberg <johan.hedberg@gmail.com>
To: Sheldon Demario <sheldon.demario@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Add sec-level option to interactive gattool
Date: Wed, 23 Feb 2011 23:56:53 -0300 [thread overview]
Message-ID: <20110224025653.GB6189@jh-x301> (raw)
In-Reply-To: <1298496610-11705-1-git-send-email-sheldon.demario@openbossa.org>
Hi Sheldon,
On Wed, Feb 23, 2011, Sheldon Demario wrote:
> + if (conn_state == STATE_CONNECTED) {
I think it'd be cleaner to have:
if (conn_state != STATE_CONNECTED)
return;
> +
> + return;
> +}
Never have empty return statements at the end of void-functions.
Johan
next prev parent reply other threads:[~2011-02-24 2:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 21:30 [PATCH] Add sec-level option to interactive gattool Sheldon Demario
2011-02-24 2:56 ` Johan Hedberg [this message]
2011-02-24 13:59 ` [PATCH v2] " Sheldon Demario
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110224025653.GB6189@jh-x301 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=sheldon.demario@openbossa.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox