Linux bluetooth development
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Andre Dieb Martins <andre.dieb@signove.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v1] Fix HCI LE advertising report dump
Date: Tue, 1 Mar 2011 15:59:27 -0300	[thread overview]
Message-ID: <20110301185927.GB32583@jh-x301> (raw)
In-Reply-To: <1298865502-12676-1-git-send-email-andre.dieb@signove.com>

Hi André,

On Mon, Feb 28, 2011, Andre Dieb Martins wrote:
> LE advertising report event has only one data block for each report.
> Thus, we can't reuse ext_inquiry_response_dump(), which loops over
> successive data blocks until reaches a zero-length one.
> 
> This commit introduces ext_inquiry_data_dump(), which dumps a frame
> containing data formatted according to [Vol 3] Part C, Section 8. This
> function is reused by ext_inquiry_response_dump().
> 
> Also adds RSSI parsing to each advertising report.
> ---
>  parser/hci.c |  146 +++++++++++++++++++++++++++++++++------------------------
>  1 files changed, 84 insertions(+), 62 deletions(-)

Pushed upstream. Thanks. I had to fix your commit message first though.
Please make sure that the lines are short enough to be properly viewable
with git log on a 80-column wide terminal (git log indents them by 4
characters).

Johan

      reply	other threads:[~2011-03-01 18:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-28  3:58 [PATCH v1] Fix HCI LE advertising report dump Andre Dieb Martins
2011-03-01 18:59 ` Johan Hedberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110301185927.GB32583@jh-x301 \
    --to=johan.hedberg@gmail.com \
    --cc=andre.dieb@signove.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox