linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@nokia.com>
To: Marco Sinigaglia <marco.sinigaglia@csr.com>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH] Adjust timeout LE and API
Date: Fri, 4 Mar 2011 15:54:35 -0300	[thread overview]
Message-ID: <20110304185435.GH21452@jh-x301> (raw)
In-Reply-To: <4D6FBAB3.20304@csr.com>

Hi Marco,

On Thu, Mar 03, 2011, Marco Sinigaglia wrote:
> The hci_send_req 100ms timeout is not enough when the chip is in deep
> sleep.  The timeout value has been hardcoded on hci_send_req call and,
> instead, it should be passed from above (for ex from
> hci_le_set_scan_enable).  This patch removes the hardcoded value from
> hci_send_req and it increases the timeout to 1000ms.
> 
> From: Marco Sinigaglia, marco.sinigaglia@csr.com
> 
> ---
>  lib/hci.c         |   12 ++++++------
>  lib/hci_lib.h     |    6 +++---
>  tools/hciconfig.c |    2 +-
>  tools/hcitool.c   |    6 +++---
>  4 files changed, 13 insertions(+), 13 deletions(-)

The patch looks good but doesn't apply with git am. Could you please
recreate it with git format-patch and resend with git send-email?
Thanks.

Johan

      reply	other threads:[~2011-03-04 18:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-03 15:58 [PATCH] Adjust timeout LE and API Marco Sinigaglia
2011-03-04 18:54 ` Johan Hedberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110304185435.GH21452@jh-x301 \
    --to=johan.hedberg@nokia.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marco.sinigaglia@csr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).